Repository navigation
Conversation
|
Nice work @wasp-bot ! Did you use any of the skills we have in the repo? E.g. review skill? |
|
Thanks! No—I didn’t invoke any repository skills for this pass, including I followed |
There was a problem hiding this comment.
Important
Before merging, preserve readable Auth UI defaults for existing apps and give the tag color picker a focus indicator distinct from its selected state.
Approach: System-driven CSS variables and a static walkthrough fit the starter refresh; the shared Auth UI also needs defaults that work without starter-specific overrides.
Reviewed changes across the starter templates, tutorial, Auth SDK, and standalone development server page.
- Starters: System colors, responsive control styling, a static walkthrough, and keyboard-selectable tag colors.
- Shared Auth UI: Customizable field colors, aligned controls, and updated headings and feedback styling.
- Tutorial and server page: Matching tutorial styles and screenshots, plus an inline theme for the existing wrong-port page without routing changes.
- Validation: Verified tutorial patch applicability and CSS parity, and reproduced the Auth UI and keyboard focus issues in isolated Chromium fixtures. I did not rerun the full app suites.
gpt-6.2-sol | 𝕏
| --color-submitButtonText: black; | ||
| --color-formErrorText: var(--color-darkRed); | ||
| --color-inputBackground: #f8f4ff; | ||
| --color-inputText: currentColor; |
There was a problem hiding this comment.
On an existing dark app that sets body { color: white; background: #111 } without overriding the new tokens, the default Auth UI now paints white input text and a white reveal icon over the unchanged pale-purple field. Chromium computes 1.08:1 contrast for the field text; before this change the same field used black text. The dummy email notice has the same mismatch with its new inherited foreground.
Technical details
# Pair default Auth UI foregrounds with their backgrounds
## Affected sites
- `packages/libs/sdk-core/src/browser/auth/forms/auth-styles.css:27-28` — the default background is fixed and pale, but the default foreground follows the surrounding app.
- `packages/libs/sdk-core/src/browser/auth/forms/FormPasswordInput.module.css:9` — the reveal button now uses the same foreground token.
- `waspc/data/Generator/templates/sdk/wasp/auth/forms/internal/email/DummyEmailSenderNotice.module.css:5-6` — the notice also uses a pale default background with inherited text.
## Required outcome
- Keep default foreground/background pairs readable without app overrides. A dark default foreground for the light field would preserve the existing behavior; let the starter and tutorial continue to override both tokens together. Pair the notice's foreground and background as well.| "hover:outline-2 hover:outline-offset-2 hover:outline-black", | ||
| checked && "outline-2 outline-offset-2 outline-black", | ||
| "border-line flex size-8 cursor-pointer items-center justify-center rounded-md border", | ||
| "peer-focus-visible:outline-ink peer-focus-visible:outline-2 peer-focus-visible:outline-offset-2", |
There was a problem hiding this comment.
Tabbing from the tag name into the color group lands on the checked swatch, but its outline looks exactly the same before and after focus. Give selection a separate visual cue, such as a checkmark, and reserve the outer outline for :focus-visible so keyboard users can tell when they have entered or left the group.
| id={id} | ||
| className={twJoin( | ||
| "w-full border-2 border-black bg-white px-4 py-3 text-black placeholder:text-gray", | ||
| "border-line bg-surface text-ink placeholder:text-gray w-full rounded-md border px-3 py-2.5", |
There was a problem hiding this comment.
The new border-line gives the task and tag text fields less than 2:1 contrast against the surrounding colors in both themes, making the editable area hard to distinguish. The same decorative border color is now used for the starter Auth UI and tutorial fields; give input borders their own token that reaches 3:1 against the adjacent surface without darkening every divider.
Technical details
# Distinguish editable fields from their surroundings
## Affected sites
- `waspc/data/Cli/starters/basic/src/shared/components/Input.tsx:22` — task and tag fields use `border-line`.
- `waspc/data/Cli/starters/basic/src/Main.css:59` and the matching minimal and tutorial copies — `--color-gray600` maps the Auth UI field border to `--line`.
- `examples/tutorials/TodoApp/src/Main.css:232` and `examples/tutorials/TodoAppTs/src/Main.css:232` — the task input gets `--line` through `--border`; its styling is also in the chapter snippet and patch.
## Required outcome
- Keep input boundaries visible before focus in both themes. Share the stronger field-border color across these consumers while leaving decorative borders unchanged.
@wasp/spec
@wasp/cli
@wasp/cli-darwin-arm64-unknown
@wasp/cli-linux-arm64-glibc
@wasp/cli-linux-x64-glibc
@wasp/cli-linux-x64-musl
commit: |

Description
Fixes #5383
Give the starters, tutorial, and development API server page a consistent, calmer design using the existing Wasp palette:
(0, 0)as clicks outside the dialog.The branded standalone server screen is called wrong-port in the current source tree; this PR updates that screen, without introducing new router/404 behavior. This is a consistency pass using today's palette, not a replacement for the designer's upcoming brand direction. No UI dependency added.
Browser previews
Full gallery: welcome, tasks, auth, minimal starter, tutorial, mobile, and server page.
The separate preview branch holds review images only and is not intended to be merged.
Validation
mise run buildwasp installandwasp compilefor isolated copies of both tutorial examples.mise run test:waspc:e2e:accept-all(withTASTY_PATTERN='Snapshot Tests').git diff --check.Existing validation limitation: full tutorial action generation gets past the changed CSS patch, then fails at the unchanged
07-auth__wasp-file-auth.patch, whose context pins Wasp^0.26.0while the starter generates^0.27.0. That unrelated patch is left unchanged.Session: http://swarm:4096/server/aHR0cDovL3N3YXJtOjQwOTY/session/ses_e05446f37ffeba0Ybl2ccSttph
Agreement
Type of change
Checklist
I tested my change in a Wasp app to verify that it works as intended.
🧪 Tests and apps:
examples/kitchen-sink/e2e-tests.waspc/data/Cli/templates, as needed.examples/, as needed.examples/tutorials) I updated the tutorial in the docs (and vice versa).📜 Documentation:
web/docs/.🆕 Changelog: (if change is more than just code/docs improvement)
waspc/ChangeLog.mdwith a user-friendly description of the change.web/docs/migration-guides/.versioninwaspc/waspc.cabalto reflect the changes I introduced.