Skip to content

Stop checking the database for pending migrations in wasp compile - #5427

Open
infomiho wants to merge 1 commit into
issue-4479-dev-db-docsfrom
issue-4479-static-wasp-compile
Open

infomiho wants to merge 1 commit into
issue-4479-dev-db-docsfrom
issue-4479-static-wasp-compile

Conversation

@infomiho

@infomiho infomiho commented Nov 20, 2026 •

Copy link
Copy Markdown
Member

Description

wasp compile command checked if the database had pending migrations which would always fail given we don't auto start the database for this command. It would just print out noise that it can't check.

image

(We added this code in a previous PR to preserve the behaviour so we can do a clean removal now)

This also drops the warning about migrations which I think it's okay?

image

Agreement

  • This is a small, obvious fix (typo, docs corrections, clear small bug with a test).
  • A maintainer agreed on the approach beforehand:

Type of change

  • 🔧 Just code/docs improvement
  • 🐞 Bug fix
  • 🚀 New/improved feature
  • 💥 Breaking change

Checklist

  • I tested my change in a Wasp app to verify that it works as intended.

  • 🧪 Tests and apps:

    • I added unit tests for my change.
    • (if you fixed a bug) I added a regression test for the bug I fixed.
    • (if you added/updated a feature) I added/updated e2e tests in examples/kitchen-sink/e2e-tests.
    • (if you added/updated a feature) I updated the starter templates in waspc/data/Cli/templates, as needed.
    • (if you added/updated a feature) I updated the example apps in examples/, as needed.
      • (if you updated examples/tutorials) I updated the tutorial in the docs (and vice versa).
  • 📜 Documentation:

    • (if you added/updated a feature) I added/updated the documentation in web/docs/.
  • 🆕 Changelog: (if change is more than just code/docs improvement)

    • I updated waspc/ChangeLog.md with a user-friendly description of the change.
    • (if you did a breaking change) I added a step to the current migration guide in web/docs/migration-guides/.
    • I bumped the version in waspc/waspc.cabal to reflect the changes I introduced.

@infomiho
infomiho added this pull request to stack #5428 November 20, 2026 10:32
@infomiho
infomiho temporarily deployed to railway-deploy-test November 20, 2026 10:49 — with GitHub Actions Inactive
@pkg-pr-new

pkg-pr-new Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

Open in StackBlitz

@wasp/spec

npx https://pkg.pr.new/@wasp/spec@5427

@wasp/cli

npx https://pkg.pr.new/@wasp/cli@5427

@wasp/cli-darwin-arm64-unknown

npx https://pkg.pr.new/@wasp/cli-darwin-arm64-unknown@5427

@wasp/cli-linux-arm64-glibc

npx https://pkg.pr.new/@wasp/cli-linux-arm64-glibc@5427

@wasp/cli-linux-x64-glibc

npx https://pkg.pr.new/@wasp/cli-linux-x64-glibc@5427

@wasp/cli-linux-x64-musl

npx https://pkg.pr.new/@wasp/cli-linux-x64-musl@5427

commit: e898103

@infomiho
infomiho force-pushed the issue-4479-static-wasp-compile branch from 6b533b5 to 1097c41 Compare November 20, 2026 13:11
@infomiho
infomiho temporarily deployed to railway-deploy-test November 20, 2026 13:16 — with GitHub Actions Inactive
@infomiho
infomiho force-pushed the issue-4479-static-wasp-compile branch from 1097c41 to 1397152 Compare November 20, 2026 13:52
@infomiho
infomiho temporarily deployed to railway-deploy-test November 20, 2026 13:59 — with GitHub Actions Inactive
@infomiho
infomiho force-pushed the issue-4479-static-wasp-compile branch from 1397152 to 68176aa Compare November 20, 2026 14:28
@infomiho
infomiho marked this pull request as ready for review November 20, 2026 14:34
@infomiho
infomiho requested review from a team and sodic November 20, 2026 14:34

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Approach: sound — database migration checks belong in the running development workflow, not standalone compilation.

Reviewed changes cover the standalone compile command and its migration-check callers.

  • Database-independent compilation: removes the development database lookup and migration warnings while retaining the exclusive project lock and normal compilation diagnostics.
  • Runtime diagnostics preserved: migration warnings remain in wasp start and watch-mode recompilation.

Validation was source inspection only; no local builds or tests were run.

Pullfrog  | View workflow run | Using gpt-6.1-sol | 𝕏

@infomiho
infomiho temporarily deployed to railway-deploy-test November 20, 2026 14:40 — with GitHub Actions Inactive
@infomiho
infomiho force-pushed the issue-4479-static-wasp-compile branch 5 times, most recently from b66287d to d7103e1 Compare November 20, 2026 20:25
@infomiho
infomiho force-pushed the issue-4479-static-wasp-compile branch from d7103e1 to e898103 Compare November 20, 2026 20:25
@infomiho
infomiho deployed to railway-deploy-test November 20, 2026 20:31 — with GitHub Actions Active
@infomiho
infomiho deployed to fly-deploy-test November 20, 2026 20:31 — with GitHub Actions Active

This branch was successfully deployed

2 active deployments
railway-deploy-test — e898103c Deployed Nov 20, 2026 by infomiho via deploy-test / Test Railway deployment #15779
fly-deploy-test — e898103c Deployed Nov 20, 2026 by infomiho via deploy-test / Test Fly deployment #15779
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant