Skip to content

Extract the dev database flags into DevDbOptions - #5287

Merged
infomiho merged 1 commit into
mainfrom
issue-4479-dev-db-options
Nov 20, 2026
Merged

infomiho merged 1 commit into
mainfrom
issue-4479-dev-db-options

Conversation

@infomiho

@infomiho infomiho commented Nov 6, 2026 •

Copy link
Copy Markdown
Member

Description

Extracts dev DB options args parser out of the db start command for later use in other commands that auto-start the dev DB.

Agreement

Type of change

  • 🔧 Just code/docs improvement
  • 🐞 Bug fix
  • 🚀 New/improved feature
  • 💥 Breaking change

Checklist

  • I tested my change in a Wasp app to verify that it works as intended.

  • 🧪 Tests and apps:

    • I added unit tests for my change.
    • (if you fixed a bug) I added a regression test for the bug I fixed.
    • (if you added/updated a feature) I added/updated e2e tests in examples/kitchen-sink/e2e-tests.
    • (if you added/updated a feature) I updated the starter templates in waspc/data/Cli/templates, as needed.
    • (if you added/updated a feature) I updated the example apps in examples/, as needed.
      • (if you updated examples/tutorials) I updated the tutorial in the docs (and vice versa).
  • 📜 Documentation:

    • (if you added/updated a feature) I added/updated the documentation in web/docs/.
  • 🆕 Changelog: (if change is more than just code/docs improvement)

    • I updated waspc/ChangeLog.md with a user-friendly description of the change.
    • (if you did a breaking change) I added a step to the current migration guide in web/docs/migration-guides/.
    • I bumped the version in waspc/waspc.cabal to reflect the changes I introduced.

@infomiho
infomiho added this pull request to stack #5286 November 6, 2026 09:33
@infomiho
infomiho marked this pull request as ready for review November 6, 2026 09:36
@infomiho
infomiho temporarily deployed to railway-deploy-test November 6, 2026 09:38 — with GitHub Actions Inactive

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes
Reviewed the complete refactor and traced the affected parser and database startup call sites for behavior preservation.

  • Shared database options: Extracts DevDbOptions and devDbOptionsParser, preserving all three flags, their validation, defaults, and help text.
  • Startup integration: Passes the options record through startPostgresDevDb and withPostgresDevDb, preserving port selection, Docker arguments, and startup messages.
  • Module registration: Exposes the new parser module through cli-lib in waspc.cabal.

Verification was by code inspection; no local tests were run. Formatting checks and the static Linux build passed in CI; other builds and tests were still in progress when checked.

Pullfrog  | View workflow run | Using gpt-6.1-sol | 𝕏

@pkg-pr-new

pkg-pr-new Bot commented Nov 6, 2026 •

Copy link
Copy Markdown

Open in StackBlitz

@wasp/spec

npx https://pkg.pr.new/@wasp/spec@5287

@wasp/cli

npx https://pkg.pr.new/@wasp/cli@5287

@wasp/cli-darwin-arm64-unknown

npx https://pkg.pr.new/@wasp/cli-darwin-arm64-unknown@5287

@wasp/cli-linux-arm64-glibc

npx https://pkg.pr.new/@wasp/cli-linux-arm64-glibc@5287

@wasp/cli-linux-x64-glibc

npx https://pkg.pr.new/@wasp/cli-linux-x64-glibc@5287

@wasp/cli-linux-x64-musl

npx https://pkg.pr.new/@wasp/cli-linux-x64-musl@5287

commit: 2fdb001

@infomiho
infomiho force-pushed the issue-4479-dev-db-options branch from 6390832 to 2fdb001 Compare November 6, 2026 10:01
@infomiho infomiho added the skip-ci Disables GitHub Workflows on this PR. label Nov 6, 2026
@infomiho
infomiho temporarily deployed to railway-deploy-test November 6, 2026 10:18 — with GitHub Actions Inactive
@infomiho
infomiho removed this pull request from stack #5286 November 7, 2026 14:53
@infomiho
infomiho added this pull request to stack #5310 November 7, 2026 14:53
@github-actions

Copy link
Copy Markdown
Contributor

This pull request is now stale.
That means that it hasn't seen any activity for a while, and needs to be updated or addressed before it can be merged.

Next steps if the PR is still relevant, and you are able to devote time to it:

  • If you received any questions or feedback, please address them.
  • Merge the latest main into your branch to ensure that you are up to date.
  • If you are still working on the changes, please leave a comment telling us so.
  • Otherwise, just leave a comment explaining why the PR is still relevant.

If no action is taken, this PR will be automatically closed in 7 days.

@github-actions github-actions Bot added the Stale label Nov 14, 2026
@infomiho
infomiho force-pushed the issue-4479-dev-db-options branch from 2fdb001 to b38fb86 Compare November 19, 2026 14:22
@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Nov 19, 2026 •

Copy link
Copy Markdown

Deploying wasp-docs-on-main with  Cloudflare Pages  Cloudflare Pages

Latest commit: 0297037
Status:⚡️  Build in progress...

View logs

@infomiho infomiho removed the Stale label Nov 19, 2026
@infomiho
infomiho removed this pull request from stack #5310 November 20, 2026 10:32
@infomiho
infomiho added this pull request to stack #5428 November 20, 2026 10:32
@infomiho
infomiho force-pushed the issue-4479-dev-db-options branch from b38fb86 to ffad1b5 Compare November 20, 2026 20:21
@infomiho
infomiho requested review from a team and viborc November 20, 2026 20:21
Base automatically changed from issue-4479-dev-db-session to main November 20, 2026 20:21
@infomiho
infomiho force-pushed the issue-4479-dev-db-options branch from ffad1b5 to 0297037 Compare November 20, 2026 20:22
@infomiho
infomiho merged commit 0df37fb into main Nov 20, 2026
15 of 16 checks passed
@infomiho
infomiho deleted the issue-4479-dev-db-options branch November 20, 2026 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-ci Disables GitHub Workflows on this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant