Repository navigation
Extract the dev database flags into DevDbOptions - #5287
Merged
Merged
Conversation
infomiho
marked this pull request as ready for review
November 6, 2026 09:36
infomiho
temporarily deployed
to
fly-deploy-test
November 6, 2026 09:38 — with
GitHub Actions
Inactive
infomiho
temporarily deployed
to
railway-deploy-test
November 6, 2026 09:38 — with
GitHub Actions
Inactive
Contributor
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
Reviewed the complete refactor and traced the affected parser and database startup call sites for behavior preservation.
- Shared database options: Extracts
DevDbOptionsanddevDbOptionsParser, preserving all three flags, their validation, defaults, and help text. - Startup integration: Passes the options record through
startPostgresDevDbandwithPostgresDevDb, preserving port selection, Docker arguments, and startup messages. - Module registration: Exposes the new parser module through
cli-libinwaspc.cabal.
Verification was by code inspection; no local tests were run. Formatting checks and the static Linux build passed in CI; other builds and tests were still in progress when checked.
gpt-6.1-sol | 𝕏
@wasp/spec
@wasp/cli
@wasp/cli-darwin-arm64-unknown
@wasp/cli-linux-arm64-glibc
@wasp/cli-linux-x64-glibc
@wasp/cli-linux-x64-musl
commit: |
infomiho
force-pushed
the
issue-4479-dev-db-options
branch
from
November 6, 2026 10:01
6390832 to
2fdb001
Compare
infomiho
temporarily deployed
to
fly-deploy-test
November 6, 2026 10:18 — with
GitHub Actions
Inactive
infomiho
temporarily deployed
to
railway-deploy-test
November 6, 2026 10:18 — with
GitHub Actions
Inactive
Contributor
|
This pull request is now stale. Next steps if the PR is still relevant, and you are able to devote time to it:
If no action is taken, this PR will be automatically closed in 7 days. |
infomiho
force-pushed
the
issue-4479-dev-db-options
branch
from
November 19, 2026 14:22
2fdb001 to
b38fb86
Compare
infomiho
force-pushed
the
issue-4479-dev-db-options
branch
from
November 20, 2026 20:21
b38fb86 to
ffad1b5
Compare
infomiho
force-pushed
the
issue-4479-dev-db-options
branch
from
November 20, 2026 20:22
ffad1b5 to
0297037
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Extracts dev DB options args parser out of the
db startcommand for later use in other commands that auto-start the dev DB.Agreement
wasp start#4914 (comment)Type of change
Checklist
I tested my change in a Wasp app to verify that it works as intended.
🧪 Tests and apps:
examples/kitchen-sink/e2e-tests.waspc/data/Cli/templates, as needed.examples/, as needed.examples/tutorials) I updated the tutorial in the docs (and vice versa).📜 Documentation:
web/docs/.🆕 Changelog: (if change is more than just code/docs improvement)
waspc/ChangeLog.mdwith a user-friendly description of the change.web/docs/migration-guides/.versioninwaspc/waspc.cabalto reflect the changes I introduced.