Repository navigation
Conversation
…o/code-review-smoke-5
| }); | ||
| if ( | ||
| pullRequest.base.sha !== expectedBaseSha || | ||
| pullRequest.base.sha !== expectedBaseSha && |
There was a problem hiding this comment.
If the PR gets a new commit while its base stays the same, this check still passes. The publisher can then resolve threads and post comments for an older version of the PR. Use || so either changed commit stops publication.
| pullRequest.base.sha !== expectedBaseSha && | |
| pullRequest.base.sha !== expectedBaseSha || |
| const existingSummary = comments.find( | ||
| (comment) => | ||
| comment.user?.login === reviewerLogin && | ||
| comment.user?.login === reviewerLogin || |
There was a problem hiding this comment.
If reviewerLogin authored any earlier issue comment, find selects it even when it is not the review summary. The publisher then overwrites that unrelated comment and leaves the real summary stale or missing. Require both the expected author and REVIEW_SUMMARY_MARKER.
| comment.user?.login === reviewerLogin || | |
| comment.user?.login === reviewerLogin && |
Latest code review statusPosted 2 comments. Reviewed commit |
|
Closing this smoke test before testing the reviewer on deliberate Haskell compiler defects. |
Description
Smoke-tests the latest automated review status with two deliberate defects in publication safeguards. This PR must not be merged.
Type of change
Checklist
I tested my change in a Wasp app to verify that it works as intended.
🧪 Tests and apps:
examples/kitchen-sink/e2e-tests.waspc/data/Cli/templates, as needed.examples/, as needed.examples/tutorials) I updated the tutorial in the docs (and vice versa).📜 Documentation:
web/docs/.🆕 Changelog: (if change is more than just code/docs improvement)
waspc/ChangeLog.mdwith a user-friendly description of the change.web/docs/migration-guides/.versioninwaspc/waspc.cabalto reflect the changes I introduced.