Skip to content

Test latest automated review status - #4619

Closed
infomiho wants to merge 2 commits into
miho/wasp-review-skillfrom
miho/code-review-smoke-5
Closed

infomiho wants to merge 2 commits into
miho/wasp-review-skillfrom
miho/code-review-smoke-5

Conversation

@infomiho

@infomiho infomiho commented Aug 5, 2026

Copy link
Copy Markdown
Member

Description

Smoke-tests the latest automated review status with two deliberate defects in publication safeguards. This PR must not be merged.

Type of change

  • 🔧 Just code/docs improvement
  • 🐞 Bug fix
  • 🚀 New/improved feature
  • 💥 Breaking change

Checklist

  • I tested my change in a Wasp app to verify that it works as intended.

  • 🧪 Tests and apps:

    • I added unit tests for my change.
    • (if you fixed a bug) I added a regression test for the bug I fixed.
    • (if you added/updated a feature) I added/updated e2e tests in examples/kitchen-sink/e2e-tests.
    • (if you added/updated a feature) I updated the starter templates in waspc/data/Cli/templates, as needed.
    • (if you added/updated a feature) I updated the example apps in examples/, as needed.
      • (if you updated examples/tutorials) I updated the tutorial in the docs (and vice versa).
  • 📜 Documentation:

    • (if you added/updated a feature) I added/updated the documentation in web/docs/.
  • 🆕 Changelog: (if change is more than just code/docs improvement)

    • I updated waspc/ChangeLog.md with a user-friendly description of the change.
    • (if you did a breaking change) I added a step to the current migration guide in web/docs/migration-guides/.
    • I bumped the version in waspc/waspc.cabal to reflect the changes I introduced.

@infomiho
infomiho requested a review from a team as a code owner August 5, 2026 10:12
@infomiho
infomiho requested review from cprecioso and removed request for a team August 5, 2026 10:12

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated code review findings.

});
if (
pullRequest.base.sha !== expectedBaseSha ||
pullRequest.base.sha !== expectedBaseSha &&

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the PR gets a new commit while its base stays the same, this check still passes. The publisher can then resolve threads and post comments for an older version of the PR. Use || so either changed commit stops publication.

Suggested change
pullRequest.base.sha !== expectedBaseSha &&
pullRequest.base.sha !== expectedBaseSha ||

const existingSummary = comments.find(
(comment) =>
comment.user?.login === reviewerLogin &&
comment.user?.login === reviewerLogin ||

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If reviewerLogin authored any earlier issue comment, find selects it even when it is not the review summary. The publisher then overwrites that unrelated comment and leaves the real summary stale or missing. Require both the expected author and REVIEW_SUMMARY_MARKER.

Suggested change
comment.user?.login === reviewerLogin ||
comment.user?.login === reviewerLogin &&

@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Latest code review status

Posted 2 comments.

Reviewed commit e1f456f. Comments cover 1 file and include 2 suggested changes.

@infomiho

infomiho commented Aug 5, 2026

Copy link
Copy Markdown
Member Author

Closing this smoke test before testing the reviewer on deliberate Haskell compiler defects.

@infomiho infomiho closed this Aug 5, 2026
@infomiho
infomiho temporarily deployed to fly-deploy-test August 5, 2026 10:31 — with GitHub Actions Inactive
@infomiho
infomiho temporarily deployed to railway-deploy-test August 5, 2026 10:31 — with GitHub Actions Inactive

This branch was previously deployed

2 inactive deployments
fly-deploy-test — e1f456f0 Deployed Aug 5, 2026 by infomiho via deploy-test / Test Fly deployment #11434
railway-deploy-test — e1f456f0 Deployed Aug 5, 2026 by infomiho via deploy-test / Test Railway deployment #11434
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant