Repository navigation
Conversation
| }); | ||
| if ( | ||
| pullRequest.base.sha !== expectedBaseSha || | ||
| pullRequest.base.sha !== expectedBaseSha && |
There was a problem hiding this comment.
If the PR gets a new head commit while its base stays the same, this check still passes. The reviewer can then publish comments for an older version of the PR, so use || to stop publication when either SHA changes.
| pullRequest.base.sha !== expectedBaseSha && | |
| pullRequest.base.sha !== expectedBaseSha || |
| const existingSummary = comments.find( | ||
| (comment) => | ||
| comment.user?.login === reviewerLogin && | ||
| comment.user?.login === reviewerLogin || |
There was a problem hiding this comment.
If github-actions[bot] posted an earlier issue comment without the summary marker, find selects that comment and replaces it with the review summary. Require both the reviewer login and REVIEW_SUMMARY_MARKER so unrelated automation comments remain intact.
| comment.user?.login === reviewerLogin || | |
| comment.user?.login === reviewerLogin && |
Code reviewFinished review of |
…o/code-review-smoke-4
| }); | ||
| if ( | ||
| pullRequest.base.sha !== expectedBaseSha || | ||
| pullRequest.base.sha !== expectedBaseSha && |
There was a problem hiding this comment.
If the PR gets a new commit while its base stays the same, this check still passes. The reviewer can then publish comments and resolve threads using the old head, so use || to stop publication when either SHA changes.
| pullRequest.base.sha !== expectedBaseSha && | |
| pullRequest.base.sha !== expectedBaseSha || |
| const existingSummary = comments.find( | ||
| (comment) => | ||
| comment.user?.login === reviewerLogin && | ||
| comment.user?.login === reviewerLogin || |
There was a problem hiding this comment.
If this bot has already posted an ordinary issue comment on the PR, find selects it even though it lacks the summary marker. Publishing the review then overwrites that unrelated comment, so require both the matching author and marker.
| comment.user?.login === reviewerLogin || | |
| comment.user?.login === reviewerLogin && |
|
Closing this smoke test before validating the adaptive latest-review status. |
@wasp.sh/spec
@wasp.sh/wasp-cli
@wasp.sh/wasp-cli-darwin-arm64-unknown
@wasp.sh/wasp-cli-darwin-x64-unknown
@wasp.sh/wasp-cli-linux-arm64-glibc
@wasp.sh/wasp-cli-linux-x64-glibc
@wasp.sh/wasp-cli-linux-x64-musl
commit: |
Description
Smoke-tests the refined automated review prose with two deliberate defects in publication safeguards. This PR must not be merged.
Type of change
Checklist
I tested my change in a Wasp app to verify that it works as intended.
🧪 Tests and apps:
examples/kitchen-sink/e2e-tests.waspc/data/Cli/templates, as needed.examples/, as needed.examples/tutorials) I updated the tutorial in the docs (and vice versa).📜 Documentation:
web/docs/.🆕 Changelog: (if change is more than just code/docs improvement)
waspc/ChangeLog.mdwith a user-friendly description of the change.web/docs/migration-guides/.versioninwaspc/waspc.cabalto reflect the changes I introduced.