Skip to content

Test refined automated review prose - #4618

Closed
infomiho wants to merge 2 commits into
miho/wasp-review-skillfrom
miho/code-review-smoke-4
Closed

infomiho wants to merge 2 commits into
miho/wasp-review-skillfrom
miho/code-review-smoke-4

Conversation

@infomiho

@infomiho infomiho commented Aug 5, 2026

Copy link
Copy Markdown
Member

Description

Smoke-tests the refined automated review prose with two deliberate defects in publication safeguards. This PR must not be merged.

Type of change

  • 🔧 Just code/docs improvement
  • 🐞 Bug fix
  • 🚀 New/improved feature
  • 💥 Breaking change

Checklist

  • I tested my change in a Wasp app to verify that it works as intended.

  • 🧪 Tests and apps:

    • I added unit tests for my change.
    • (if you fixed a bug) I added a regression test for the bug I fixed.
    • (if you added/updated a feature) I added/updated e2e tests in examples/kitchen-sink/e2e-tests.
    • (if you added/updated a feature) I updated the starter templates in waspc/data/Cli/templates, as needed.
    • (if you added/updated a feature) I updated the example apps in examples/, as needed.
      • (if you updated examples/tutorials) I updated the tutorial in the docs (and vice versa).
  • 📜 Documentation:

    • (if you added/updated a feature) I added/updated the documentation in web/docs/.
  • 🆕 Changelog: (if change is more than just code/docs improvement)

    • I updated waspc/ChangeLog.md with a user-friendly description of the change.
    • (if you did a breaking change) I added a step to the current migration guide in web/docs/migration-guides/.
    • I bumped the version in waspc/waspc.cabal to reflect the changes I introduced.

@infomiho
infomiho requested a review from a team as a code owner August 5, 2026 09:28
@infomiho
infomiho requested review from FranjoMindek and removed request for a team August 5, 2026 09:28

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated code review findings.

});
if (
pullRequest.base.sha !== expectedBaseSha ||
pullRequest.base.sha !== expectedBaseSha &&

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the PR gets a new head commit while its base stays the same, this check still passes. The reviewer can then publish comments for an older version of the PR, so use || to stop publication when either SHA changes.

Suggested change
pullRequest.base.sha !== expectedBaseSha &&
pullRequest.base.sha !== expectedBaseSha ||

const existingSummary = comments.find(
(comment) =>
comment.user?.login === reviewerLogin &&
comment.user?.login === reviewerLogin ||

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If github-actions[bot] posted an earlier issue comment without the summary marker, find selects that comment and replaces it with the review summary. Require both the reviewer login and REVIEW_SUMMARY_MARKER so unrelated automation comments remain intact.

Suggested change
comment.user?.login === reviewerLogin ||
comment.user?.login === reviewerLogin &&

@github-actions

github-actions Bot commented Aug 5, 2026 •

Copy link
Copy Markdown
Contributor

Code review

Finished review of 7e005b2ac75a0eebc1e16dc7779992eb8e17afb9: posted 2 comments and resolved 0 threads.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated code review findings.

});
if (
pullRequest.base.sha !== expectedBaseSha ||
pullRequest.base.sha !== expectedBaseSha &&

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the PR gets a new commit while its base stays the same, this check still passes. The reviewer can then publish comments and resolve threads using the old head, so use || to stop publication when either SHA changes.

Suggested change
pullRequest.base.sha !== expectedBaseSha &&
pullRequest.base.sha !== expectedBaseSha ||

const existingSummary = comments.find(
(comment) =>
comment.user?.login === reviewerLogin &&
comment.user?.login === reviewerLogin ||

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this bot has already posted an ordinary issue comment on the PR, find selects it even though it lacks the summary marker. Publishing the review then overwrites that unrelated comment, so require both the matching author and marker.

Suggested change
comment.user?.login === reviewerLogin ||
comment.user?.login === reviewerLogin &&

@infomiho
infomiho temporarily deployed to railway-deploy-test August 5, 2026 09:59 — with GitHub Actions Inactive
@infomiho
infomiho temporarily deployed to fly-deploy-test August 5, 2026 09:59 — with GitHub Actions Inactive
@infomiho

infomiho commented Aug 5, 2026

Copy link
Copy Markdown
Member Author

Closing this smoke test before validating the adaptive latest-review status.

@infomiho infomiho closed this Aug 5, 2026
@pkg-pr-new

pkg-pr-new Bot commented Aug 5, 2026

Copy link
Copy Markdown

Open in StackBlitz

@wasp.sh/spec

npx https://pkg.pr.new/wasp-lang/wasp/@wasp.sh/spec@4618

@wasp.sh/wasp-cli

npx https://pkg.pr.new/wasp-lang/wasp/@wasp.sh/wasp-cli@4618

@wasp.sh/wasp-cli-darwin-arm64-unknown

npx https://pkg.pr.new/wasp-lang/wasp/@wasp.sh/wasp-cli-darwin-arm64-unknown@4618

@wasp.sh/wasp-cli-darwin-x64-unknown

npx https://pkg.pr.new/wasp-lang/wasp/@wasp.sh/wasp-cli-darwin-x64-unknown@4618

@wasp.sh/wasp-cli-linux-arm64-glibc

npx https://pkg.pr.new/wasp-lang/wasp/@wasp.sh/wasp-cli-linux-arm64-glibc@4618

@wasp.sh/wasp-cli-linux-x64-glibc

npx https://pkg.pr.new/wasp-lang/wasp/@wasp.sh/wasp-cli-linux-x64-glibc@4618

@wasp.sh/wasp-cli-linux-x64-musl

npx https://pkg.pr.new/wasp-lang/wasp/@wasp.sh/wasp-cli-linux-x64-musl@4618

commit: 7e005b2

This branch was previously deployed

2 inactive deployments
railway-deploy-test — 7e005b2a Deployed Aug 5, 2026 by infomiho via deploy-test / Test Railway deployment #11427
fly-deploy-test — 7e005b2a Deployed Aug 5, 2026 by infomiho via deploy-test / Test Fly deployment #11427
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant