Skip to content

fix(features): enable ImeMarkedText on macOS regardless of release_bundle #10547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
spalagu wants to merge 1 commit into
base: master
Choose a base branch
from
+9 −0
Open

fix(features): enable ImeMarkedText on macOS regardless of release_bundle #10547

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions app/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2458,6 +2458,15 @@ pub fn enabled_features() -> HashSet<FeatureFlag> {
flags.extend(features::RELEASE_FLAGS);
}

// IME marked text is the only piece of CJK / dead-key Latin / emoji-candidate input
// rendering on macOS — without this flag, `setMarkedText:` calls are short-circuited in
// the terminal view and no preedit is ever drawn, breaking text input for any user with
// an IME enabled. Stable / Preview macOS already enable it via RELEASE_FLAGS, but the
// OSS distribution doesn't pass `feature = "release_bundle"`, so the flag stays off and
// CJK users effectively can't type. Enable it unconditionally on macOS to match.
#[cfg(target_os = "macos")]
flags.insert(FeatureFlag::ImeMarkedText);

flags.extend([
#[cfg(feature = "autoupdate")]
FeatureFlag::Autoupdate,
Expand Down