fix: improve Hermes CLI agent integration#10546
Draft
oz-for-oss[bot] wants to merge 2 commits intomasterfrom
Draft
fix: improve Hermes CLI agent integration#10546oz-for-oss[bot] wants to merge 2 commits intomasterfrom
oz-for-oss[bot] wants to merge 2 commits intomasterfrom
Conversation
Co-Authored-By: Sourabh Sharma <240267702+xsourabhsharma@users.noreply.github.com>
Co-Authored-By: Sourabh Sharma <240267702+xsourabhsharma@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #9745
Description
This update improves first-class Hermes CLI agent support in Warp. It keeps CLI agent toolbars available in alt-screen sessions, aligns
hermes chatRich Input submission with other interactive CLI agents that require delayed Enter handling, and updates user-facing CLI agent settings/onboarding copy to list Hermes alongside Claude Code, Codex, and Gemini.It also adds regression coverage for Hermes command detection, Rich Input hint text, and delayed Enter submission behavior.
Linked Issue
ready-to-specorready-to-implement.Testing
cargo fmtgit --no-pager diff --checkCARGO_BUILD_JOBS=1 cargo check --manifest-path /workspace/warp/Cargo.toml -p warpCARGO_BUILD_JOBS=1 cargo clippy -p warp --lib --all-features -- -D warningscargo test --manifest-path /workspace/warp/Cargo.toml -p warp test_detect -- --nocapture(attempted, but the sandbox killed the test build with SIGKILL)CARGO_BUILD_JOBS=1 CARGO_PROFILE_TEST_DEBUG=0 cargo test --manifest-path /workspace/warp/Cargo.toml -p warp submit_cli_agent_rich_input_hermes_defers_enter -- --nocapture(attempted, but the sandbox killed the test build with SIGKILL)CARGO_BUILD_JOBS=1 cargo clippy --workspace --all-targets --all-features --tests -- -D warnings(attempted, but failed before linting on missing generatedlocal_config.jsonfor release-bundle binaries in this environment)I have manually tested my changes locally with
./script/runScreenshots / Videos
Not included; this is a terminal behavior/test coverage change.
Agent Mode