Always show workflow editor close button (#10387)#10540
Open
SagarSDagdu wants to merge 1 commit intowarpdotdev:masterfrom
Open
Always show workflow editor close button (#10387)#10540SagarSDagdu wants to merge 1 commit intowarpdotdev:masterfrom
SagarSDagdu wants to merge 1 commit intowarpdotdev:masterfrom
Conversation
The "x" close affordance on the workflow/alias editor pane was hidden until the header was hovered, making dismissal hard to discover and easy to confuse with closing the entire session via the vertical tabs. Set `always_show_icons = true` on the standard header options for `WorkflowView::render_header_content` so the close button is persistently visible, matching the pattern already used by `network_log_view` and `execution_profiles/editor`.
github-actions
Bot
added
the
external-contributor
Contributor
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I reviewed this pull request and requested human review from: Comment Powered by Oz |
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Overview
This PR updates WorkflowView header rendering so standard header icons, including the close button, are always visible for the workflow/alias editor pane.
Concerns
- None found in the reviewed diff.
Verdict
Found: 0 critical, 0 important, 0 suggestions
Approve
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #10387 — the "x" close button on the workflow/alias editor pane is currently hidden until the header is hovered, which makes dismissal hard to discover. Users may attempt to close the editor via the vertical tabs "x" instead, which closes the entire session.
This change sets
always_show_icons = trueon the standard header options returned byWorkflowView::render_header_content, so the pane's close button stays persistently visible — matching the pattern already used bynetwork_log_viewandai/execution_profiles/editor.Single-file change in
app/src/workflows/workflow_view.rs.Linked Issue
ready-to-implement.Closes #10387
Screenshots / Videos
https://www.loom.com/share/34f7fb67766041b684877ef923d222c2
Testing
cargo fmtandcargo clippy -p warp --bin warp-oss --all-targets(clean).No automated test added: similar UX-flag fixes elsewhere in the codebase (
network_log_view.rs,ai/execution_profiles/editor/mod.rs) togglealways_show_iconswithout dedicated tests, since the change is a single render-time boolean and asserting on rendered header visibility would require new test scaffolding (aHeaderRenderContexttest fixture and aWorkflowViewsingleton-soup setup) for limited additional confidence.Agent Mode