Skip to content

Improve CLI agent pane summary labels#10530

Open
nextbysam wants to merge 1 commit intowarpdotdev:masterfrom
nextbysam:agent-pane-summary-labels
Open

Improve CLI agent pane summary labels#10530
nextbysam wants to merge 1 commit intowarpdotdev:masterfrom
nextbysam:agent-pane-summary-labels

Conversation

@nextbysam
Copy link
Copy Markdown

Summary

  • Detect when the vertical-tabs context menu target is a known CLI agent pane.
  • Label the existing custom pane-title action as "Edit agent summary" for CLI agent panes, with matching reset copy.
  • Keep the existing "Rename pane" labels for regular terminal panes.

Why

When several CLI agent panes are open in the same Warp window, it is hard to tell which pane is doing what. Autogenerated agent pane labels can be stale or unavailable depending on the agent integration; Codex currently only provides coarse notification/status events, so it often falls back to showing the working directory. Warp already persists a custom vertical-tabs title per pane, so this makes that existing override more discoverable for agent panes without changing storage or agent protocol behavior.

Testing

  • rustfmt app/src/workspace/view.rs app/src/workspace/view_tests.rs
  • git diff --check
  • cargo test -p warp pane_name_menu_labels --lib (blocked locally: warpui build requires the Metal Toolchain; build.rs reports cannot execute tool metal and suggests xcodebuild -downloadComponent MetalToolchain)

@cla-bot
Copy link
Copy Markdown

cla-bot Bot commented May 8, 2026

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @nextbysam on file. In order for us to review and merge your code, each contributor must visit https://cla.warp.dev to read and agree to our CLA. Once you have done so, please comment @cla-bot check to trigger another check.

@oz-for-oss
Copy link
Copy Markdown
Contributor

oz-for-oss Bot commented May 8, 2026

@nextbysam

I'm starting a first review of this pull request.

You can view the conversation on Warp.

I completed the review and no human review was requested for this pull request.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

@github-actions github-actions Bot added the external-contributor Indicates that a PR has been opened by someone outside the Warp team. label May 8, 2026
Copy link
Copy Markdown
Contributor

@oz-for-oss oz-for-oss Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview

This PR changes the vertical-tabs pane context menu so known CLI agent panes use agent-summary wording for the existing custom pane title action, while regular terminal panes keep the rename wording.

Concerns

  • Manual testing is required for changes that can be manually tested. Please include screenshots or a screen recording that show the updated context-menu labels working end to end for CLI agent and regular terminal panes, or justify why manual testing is not possible.

Verdict

Found: 0 critical, 1 important, 0 suggestions

Request changes

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

external-contributor Indicates that a PR has been opened by someone outside the Warp team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant