Skip to content

[Quality-547] Update bert_tiny model to the retrained classifier #10529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
evelyn-with-warp wants to merge 1 commit into
base: master
Choose a base branch
from
+1 −1
Open

[Quality-547] Update bert_tiny model to the retrained classifier #10529

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file renamed ...put_classifier/models/onnx/bert_tiny.onnx → ...sifier/models/onnx/bert_tiny_2026May.onnx
View file
Open in desktop
Binary file not shown.
2 changes: 1 addition & 1 deletion crates/input_classifier/src/onnx/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ impl Model {

fn model_path(&self) -> &'static str {
match self {
Model::BertTiny => "bert_tiny.onnx",
Model::BertTiny => "bert_tiny_2026May.onnx",
Copy link
Copy Markdown
Contributor

@oz-for-oss oz-for-oss Bot May 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 [SUGGESTION] Consider a versioning scheme that doesn't encode calendar dates (e.g. bert_tiny_v2.onnx). Date-suffixed names become ambiguous when multiple retrains happen in the same month and make it harder to correlate with training metadata.

Copy link
Copy Markdown
Contributor Author

@evelyn-with-warp evelyn-with-warp May 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@szgupta @vorporeal is this a real concern (as we won't refresh this often)? if so, could you suggest proper model versioning strategy for client app?

}
}

Expand Down
Loading