Add stop and kill actions for orchestration pills#10526
Draft
Add stop and kill actions for orchestration pills#10526
Conversation
Co-Authored-By: Oz <oz-agent@warp.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds Stop and Kill actions to orchestration pill overflow menus. Stop cooperatively cancels running child agents, while Kill tears down the child pane/conversation and tombstones its run ID so late events are dropped. Kill also sends one final synthetic
Cancelledlifecycle event to the parent before tombstoning so the parent is informed that the child was killed.Linked Issue
N/A
ready-to-specorready-to-implement.Testing
Skipped additional checks before creating this PR per request. Earlier validation on this branch:
cargo fmtcargo test -p warp --lib orchestration_events -- --nocapturecargo test -p warp --lib orchestration_event_streamer -- --nocapturecargo check -p warpI have manually tested my changes locally with
./script/runScreenshots / Videos
Not included.
Agent Mode
CHANGELOG-OZ: Added Stop and Kill controls for orchestration child-agent pills.
Co-Authored-By: Oz oz-agent@warp.dev