Skip to content

fix: propagate --conversation to SpawnAgentRequest for run-cloud #10524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
liliwilson wants to merge 1 commit into
base: master
Choose a base branch
from
+27 −1
Draft

fix: propagate --conversation to SpawnAgentRequest for run-cloud #10524

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/src/ai/agent_sdk/ambient.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -491,7 +491,7 @@ impl AmbientAgentRunner {
parent_run_id: None,
runtime_skills: vec![],
referenced_attachments: vec![],
conversation_id: None,
conversation_id: args.conversation,
initial_snapshot_token: None,
};

Expand Down
26 changes: 26 additions & 0 deletions crates/warp_cli/src/lib_tests.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1601,6 +1601,32 @@ fn harness_parse_local_child_harness_accepts_codex() {
);
}

#[test]
fn agent_run_cloud_accepts_conversation_flag() {
let args = Args::try_parse_from([
"warp",
"agent",
"run-cloud",
"--prompt",
"hello",
"--conversation",
"92b8aa0f-1525-4813-9990-62db7afe9c12",
])
.unwrap();

let Some(Command::CommandLine(boxed_cmd)) = args.command else {
panic!("Expected `warp agent run-cloud` command");
};
let CliCommand::Agent(AgentCommand::RunCloud(run_args)) = boxed_cmd.as_ref() else {
panic!("Expected `warp agent run-cloud` command");
};

assert_eq!(
run_args.conversation.as_deref(),
Some("92b8aa0f-1525-4813-9990-62db7afe9c12")
);
}

#[test]
fn agent_run_cloud_accepts_claude_auth_secret_with_harness() {
let args = Args::try_parse_from([
Expand Down