Skip to content

Fix ambient session cleanup on pane close#10510

Draft
zachbai wants to merge 1 commit intomasterfrom
zb/fix-cloud-agent-close-navigation
Draft

Fix ambient session cleanup on pane close#10510
zachbai wants to merge 1 commit intomasterfrom
zb/fix-cloud-agent-close-navigation

Conversation

@zachbai
Copy link
Copy Markdown
Contributor

@zachbai zachbai commented May 8, 2026

Summary

  • Unregister ambient session mappings for every terminal view in a pane stack when a pane detaches, and re-register them when it reattaches.
  • Replace stale ambient task mappings when the same task is registered for a newer terminal view.
  • Ignore hidden panes when looking for an already-open ambient agent conversation.

Tests

  • CARGO_BUILD_JOBS=1 cargo nextest run --manifest-path /workspace/warp/Cargo.toml -p warp -E 'test(ambient_session_registration_replaces_stale_terminal_for_same_task) | test(ambient_session_unregister_keeps_task_open_until_last_terminal_is_removed) | test(test_resolve_open_action_reopens_ambient_session_after_terminal_unregister)'

Co-Authored-By: Oz oz-agent@warp.dev

Conversation: https://staging.warp.dev/conversation/cea617fb-5ea0-4e0b-8f27-6078accad759
Run: https://oz.staging.warp.dev/runs/019e0919-5caa-7ec5-acd6-160481714093
This PR was generated with Oz.

@cla-bot cla-bot Bot added the cla-signed label May 8, 2026
Co-Authored-By: Oz <oz-agent@warp.dev>
@zachbai zachbai force-pushed the zb/fix-cloud-agent-close-navigation branch from 9fbda21 to 38f1475 Compare May 8, 2026 21:21
Copy link
Copy Markdown
Contributor Author

zachbai commented May 8, 2026

This stack of pull requests is managed by Graphite. Learn more about stacking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant