Skip to content

feat(weave): spans-source alerting schema + gate #7204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
gtarpenning wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

feat(weave): spans-source alerting schema + gate #7204

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions weave/trace_server/clickhouse_trace_server_batched.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6902,8 +6902,11 @@ def agent_conversation_chat(
def genai_otel_export(self, req: GenAIOTelExportReq) -> GenAIOTelExportRes:
res, span_rows = AgentWriteHandler(self.ch_client).insert_otel_spans(req)

# Return early without emitting kafka events if online eval or agent scoring are disabled
if not wf_env.wf_enable_online_eval() or not wf_env.wf_enable_agent_scoring():
# Skip the kafka emit unless online eval is on and at least one consumer
# (agent scoring or spans alerting) wants the turn-ended events.
if not wf_env.wf_enable_online_eval() or not (
wf_env.wf_enable_agent_scoring() or wf_env.wf_enable_agent_alerting()
):
return res

# Emit for each row that produces a valid event type
Expand Down
9 changes: 9 additions & 0 deletions weave/trace_server/environment.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,15 @@ def wf_enable_agent_scoring() -> bool:
return os.environ.get("WEAVE_ENABLE_AGENT_SCORING", "false").lower() == "true"


def wf_enable_agent_alerting() -> bool:
"""Whether the alert worker consumes turn-ended events for spans alerts.

Gates the same OTel-ingest emit as agent scoring so spans alerting works
even when scoring is off. Also requires `wf_enable_online_eval`.
"""
return os.environ.get("WEAVE_ENABLE_AGENT_ALERTING", "false").lower() == "true"


def wf_scoring_worker_batch_size() -> int:
"""The batch size for the scoring worker."""
return int(
Expand Down
12 changes: 11 additions & 1 deletion weave/trace_server/interface/builtin_object_classes/alert_spec.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,10 @@ class WeaveMetricThresholdSpec(BaseModel):
default="THRESHOLD",
description="Trigger condition type (e.g. 'THRESHOLD')",
)
source_type: Literal["calls", "spans"] = Field(
default="calls",
description="Data source this alert evaluates: calls table or agent spans",
)
comparison_operator: Literal["GREATER_THAN", "LESS_THAN", "EQUAL"] = Field(
default="GREATER_THAN",
description="Direction of the threshold comparison",
Expand Down Expand Up @@ -53,10 +57,16 @@ class WeaveMetricThresholdSpec(BaseModel):
"Disambiguates scorers that share the same op class (e.g. multiple LLMAsAJudgeScorer instances). "
"Filterable via inputs.self on scorer calls or input_refs on CallsFilter.",
)
aggregation_function: Literal["mean", "median", "min", "max", "mode"] = Field(
aggregation_function: Literal[
"mean", "median", "min", "max", "mode", "percentage", "count"
] = Field(
default="mean",
description="Aggregation function applied to metric values within the window before threshold comparison",
)
status_match_value: str | None = Field(
default=None,
description="For percentage/count aggregation: the status value to match (e.g. '2' for error)",
)


class AlertSpec(base_object_def.BaseObject):
Expand Down
Loading