chore(weave): add dataset_sources table migration#7198
Draft
jwlee64 wants to merge 1 commit into
Draft
Conversation
New ClickHouse table linking dataset rows to their provenance sources (calls / agent spans). ReplacingMergeTree(updated_at) keyed on (project_id, dataset_object_id, row_digest, source_kind, source_id); bloom filters on source_id and source_trace_id power reverse lookups. Insert-only versioning: reads collapse via GROUP BY + argMax, never FINAL (benchmarked: FINAL is ~100x slower on the reverse lookup at 100M rows). Shared membership-pattern invariants documented in weave/trace_server/docs/membership_pattern.md, referenced from the annotation_queues query builder (the first pattern instance).
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
What does the PR do? Include a concise description of the PR contents.
Testing
How was this PR tested?