fix(weave): exempt started_at from float convert in saved view filters#7192
Open
gtarpenning wants to merge 1 commit into
Open
fix(weave): exempt started_at from float convert in saved view filters#7192gtarpenning wants to merge 1 commit into
gtarpenning wants to merge 1 commit into
Conversation
A numeric filter on started_at wrapped the DateTime64 column in $convert -> double, producing toFloat64OrNull(started_at) which ClickHouse 25.12 rejects. The frontend already exempts started_at (#35256); this brings the Python SDK to parity. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Preview this PR with FeatureBee: https://beta.wandb.ai/?betaVersion=806927f02c402e213a3f89c60a39ee7375505390 |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
started_atwrapped theDateTime64column in$convert -> double, so the server emittedtoFloat64OrNull(any(started_at)), which ClickHouse 25.12 rejects (*OrNulltakes String only) -> 403QueryIllegalTypeofArgumentErrorin prod.FIELDS_NO_FLOAT_CONVERTonly listedsummary.weave.latency_ms. The frontend addedstarted_atin #35256 (2025-10-13); the Python SDK (saved_view.py, ported in chore(weave): add option+click support to Name and Latency #4385) was never updated, so SDK-built queries kept casting it. This fixes that divergence.Impact
Datadog last 15d: 16 failed read requests, 5 users / 4 entities. Read-only paths (
/calls/stream_query,/calls/query_stats) -> no data loss; users get a 403 when filtering calls bystarted_at.Testing
unit test asserts started_at/latency_ms stay bare
$getFieldwhile JSON fields keep the$convert; fails on master with the exact prod payload.