feat(weave): add status/last_error fields to Monitor#7188
Draft
gtarpenning wants to merge 3 commits into
Draft
Conversation
Add optional status/last_error/last_error_at health fields to the Monitor object so the scoring worker can record scoring health and the frontend can surface it. Schema + round-trip tests only; the worker lands in a stacked wandb/core PR. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Adding status/last_error/last_error_at to Monitor changed the serialized JSON, breaking the Monitor and ClassifierMonitor serialization-correctness golden cases. Per the file's methodology, add legacy copies (Monitor v3, ClassifierMonitor v1) preserving the pre-health-field format, then update the non-legacy goldens with the three new None-default fields. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
status/last_error/last_error_atto theMonitorobject so scoring health can be recorded and surfaced.Testing
flow shard: defaults-None, set-value model_validate round-trip, publish/get round-trip, invalid-status rejection.