style: apply /style-guide pass to models/reports#2723
Open
johndmulhausen wants to merge 3 commits into
Open
Conversation
Contributor
|
Preview deployment for your docs. Learn more about Mintlify Previews.
|
Contributor
🔗 Link Checker Results✅ All links are valid! No broken links were detected. Checked against: https://wb-21fd5541-style-guide-models-reports-20260604-112843.mintlify.app |
Contributor
📚 Mintlify Preview Links📝 Changed (7 total)📄 Pages (7)
🤖 Generated automatically when Mintlify deployment succeeds |
68efc48 to
5b42e34
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR applies an automated style-guide pass to the Reports documentation under models/reports, aiming to improve consistency and readability without intentionally changing technical meaning.
Changes:
- Updates frontmatter keywords and refines wording across multiple Reports docs pages.
- Clarifies/expands several procedural descriptions (sharing, embedding, cross-project reporting, cloning/exporting).
- Normalizes some headings, UI terminology, and explanatory phrasing.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| models/reports/clone-and-export-reports.mdx | Minor wording/alt-text updates and adds a post-save outcome sentence for the API cloning flow. |
| models/reports/collaborate-on-reports.mdx | Restructures intro/share/edit/comment/star sections and reorders the sharing GIF placement. |
| models/reports/create-a-report.mdx | Rewrites the intro, tweaks steps/alt text, and lightly refines API instructions. |
| models/reports/cross-project-reports.mdx | Expands the introduction and refines view-only link explanations and “send to report” wording. |
| models/reports/edit-a-report.mdx | Broad set of style edits across many sections (terminology, steps, class-name casing in prose). |
| models/reports/embed-reports.mdx | Refines the embed instructions and strengthens Confluence/Notion explanatory text. |
| models/reports/reports-gallery.mdx | Updates keywords, expands the intro sentence, and refines headings and link lead-ins. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- reports-gallery: drop the duplicate article in "See the [The View from the Driver's Seat]" (link text already begins with "The") - cross-project-reports: format the view-only tooltip string as inline code instead of bold, so readers can match the exact UI text - edit-a-report: correct "report name" to "run name" in the run-rename step - edit-a-report: match prose API references to the snippets — wr.MarkdownBlock and the report's blocks attribute — instead of the stale wandb.apis.reports.* module path (fixes the flagged MarkdownBlock line plus the two identical blocks-attribute references in the same file for consistency) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Restore the `keywords` frontmatter in the four affected Reports pages to their pre-PR (main) values. All other style edits from the pass remain. - clone-and-export-reports.mdx - create-a-report.mdx - embed-reports.mdx - reports-gallery.mdx Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR applies the
/style-guideskill (Google Developer Style Guide + CoreWeave conventions) to the Reports section undermodels/reports. The run was automated; no technical content was intentionally changed.Files edited
models/reports/clone-and-export-reports.mdxmodels/reports/collaborate-on-reports.mdxmodels/reports/create-a-report.mdxmodels/reports/cross-project-reports.mdxmodels/reports/edit-a-report.mdxmodels/reports/embed-reports.mdxmodels/reports/reports-gallery.mdxRecommendations for technical review
Prerequisites
wrwithout showing or linking the import (e.g.,import wandb_workspaces.reports.v2 as wr) — confirm whether to add or link this prerequisite (clone-and-export-reports.mdx).PROJECTandENTITYplaceholders are introduced inline; consider linking to the entities/projects concept pages, and note CoreWeave convention prefers[ALL-CAPS-HYPHENATED]placeholders — converting requires touching code samples (clone-and-export-reports.mdx).create-a-report.mdx(API tab) has no prerequisites section; consider whether to require an authenticated W&B environment, a supported Python version, or awandb loginstep.collaborate-on-reports.mdxlists no prerequisites (team/project/org membership, role or permission level required to share, edit, comment, or star) — consider adding one.embed-reports.mdxlacks a brief prerequisites section (e.g., a published report URL or specific sharing permissions).cross-project-reports.mdxdoes not define "run set" or link to run set documentation, references "private/team/public/open project" without linking project-visibility docs, and uses "magic link" and "view-only link" interchangeably without defining them together.Verification steps
clone-and-export-reports.mdx(UI export, UI clone, API clone) has a "you should see..." statement after the procedure.collaborate-on-reports.mdx: after Save to report, the doc does not describe how a reader confirms changes were saved (status indicator, draft location if not published); and after Invite or sharing link, no way to verify the recipient has access or to revoke it.create-a-report.mdx(Report tab) ends at "Click Create report" without describing the resulting screen; the W&B App tab step 4 outcome ("A draft report is saved automatically") could cross-link to the publish/edit workflow.cross-project-reports.mdx: no way to confirm a cross-project pull worked (e.g., expected run set table state), and no way to confirm a view-only link works or to revoke/rotate the secret token.edit-a-report.mdx: Visualize relationships across multiple dimensions ends without a screenshot, sample output, or rendered example.embed-reports.mdx: the HTMLiframeprocedure does not describe what the embedded report should look like once pasted.Technical accuracy
clone-and-export-reports.mdx: confirm the action menu > Download > PDF/LaTeX click path is current; confirmwr.Report.from_url(report.url)is still the recommended clone-via-API workflow; the top-level<Note>about Public Preview applies only to the API tab and may need to be scoped.collaborate-on-reports.mdx: the "edit conflict" warning is mentioned but the resolution UI and user options aren't described; confirm the Invite and Share button labels still match the current UI; consider whether full-screen panel URL-sharing belongs under "Share a report" or in a panels/embedding section.create-a-report.mdx: confirm whetherReportshould be styled as a class name (Reportclass) or remain prose (line 53); confirm "select the Filter run sets option" sufficiently conveys reversibility after the redundant toggle phrasing was removed.cross-project-reports.mdx: the statement that history data on time series lines is supported but summary metrics across projects aren't could use a concrete example or workaround link; the "add a tag and move runs" workaround has no link to instructions for moving runs between projects.edit-a-report.mdx: step 2 in Visualize relationships across multiple dimensions ("Highlight key trends. Hover over a specific group of runs to highlight them in the visualization") reads more like a tip than a sequential step; the audit pass changed`run sets`to`runsets`(line 99) to match therunsets=parameter — confirm; the audit pass unified the Tabs title toApp UIacross all Tabs sections (previously two used "W&B App") — confirm which label is canonical.embed-reports.mdx: verify only fully public reports embed correctly versus reports shared via magic links or team visibility (line 16); reconcile Confluence guidance — prose says "insert the direct link... within aniframecell," but the HTML section instructs copying a full<iframe>embed code (line 25); verify Confluence has a built-iniframemacro versus requiring an add-on (line 25); confirm Notion'sEmbedblock accepts the full embed code, not just a report URL (line 33); verify the Gradio f-string<iframe>(no closing tag) renders correctly ingr.HTML(line 48); confirm the Share button is still in the upper right of a report (line 13).reports-gallery.mdx: verify external link liveness — all example report links point to publicwandb.ai/stacey/...URLs plus abit.ly/wandb-learning-dexterityshortlink, which can rot.Missing content
clone-and-export-reports.mdx: no troubleshooting guidance for failed exports or clones (e.g., team permissions when cloning).collaborate-on-reports.mdx: no coverage of how to stop sharing, remove a collaborator, or change permissions; who can see comments, whether comments support mentions/notifications, or how to resolve/delete them; whether starred reports are visible only to the current user or to the team (the closing sentence implies the latter); and no links to related concepts (Reports overview, project/team permissions, panels).create-a-report.mdx(API tab): nowandb.login()or authentication step is shown beforereport.save()— confirm whether intentional.cross-project-reports.mdx: no procedure for generating or toggling a view-only link in the UI (only what view-only mode is); no mention of where in the UI to find the project selector beyond "in the run set table"; no guidance on choosing a destination report for Add to report (new vs. existing).edit-a-report.mdx: introduction lists no prerequisites beyond thepip installNote; the Group runs by config values code example (lines 250–264) has uneven indentation in thereport.blocksliteral.embed-reports.mdx: the Gradio example URL is hardcoded to_scott/pytorch-sweeps-demo/...(an individual user's report) — consider a placeholder or a canonical W&B-owned sample.reports-gallery.mdx: intro doesn't explicitly name the audience (first-time authors vs. experienced users looking for templates); the Notes section bundles two distinct example patterns under one H2 — consider splitting; all three H2 headings use aLabel: actioncolon pattern unusual for the style guide — consider refactoring as H2 label + H3 subtitle or dropping the labels.How to review