Skip to content

Fix paginate() to avoid redundant get_breads() queryset evaluation #668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Kkt04 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix paginate() to avoid redundant get_breads() queryset evaluation #668

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions bakerydemo/breads/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,8 @@ def children(self):
# Pagination for the index page. We use the `django.core.paginator` as any
# standard Django app would, but the difference here being we have it as a
# method on the model rather than within a view function
def paginate(self, request, *args):
def paginate(self, request, queryset=None):
queryset = queryset or self.get_breads()
page = request.GET.get("page")
paginator = Paginator(self.get_breads(), 12)
try:
Expand All @@ -254,7 +255,7 @@ def get_context(self, request):
context = super(BreadsIndexPage, self).get_context(request)

# BreadPage objects (get_breads) are passed through pagination
breads = self.paginate(request, self.get_breads())
breads = self.paginate(request)

context["breads"] = breads

Expand Down