Skip to content

대표시간표 해제 500 에러 해결 #502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
asp345 merged 2 commits into from
Apr 4, 2026
Merged

대표시간표 해제 500 에러 해결 #502

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
754e985
대표 시간표 지정 해제 멱등성 보장
asp345 Apr 2, 2026
db1c1cb
TimetableNotPrimaryException ErrorType 수정
asp345 Apr 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/src/main/kotlin/common/exception/SnuttException.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ object TimetableNotFoundException : SnuttException(ErrorType.TIMETABLE_NOT_FOUND

object PrimaryTimetableNotFoundException : SnuttException(ErrorType.PRIMARY_TIMETABLE_NOT_FOUND)

object TimetableNotPrimaryException : SnuttException(ErrorType.DEFAULT_ERROR)
object TimetableNotPrimaryException : SnuttException(ErrorType.TIMETABLE_NOT_PRIMARY)

object ConfigNotFoundException : SnuttException(ErrorType.CONFIG_NOT_FOUND)

Expand Down
3 changes: 1 addition & 2 deletions core/src/main/kotlin/timetables/service/TimetableService.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ import com.wafflestudio.snutt.common.exception.InvalidTimetableTitleException
import com.wafflestudio.snutt.common.exception.PrimaryTimetableNotFoundException
import com.wafflestudio.snutt.common.exception.TableDeleteErrorException
import com.wafflestudio.snutt.common.exception.TimetableNotFoundException
import com.wafflestudio.snutt.common.exception.TimetableNotPrimaryException
import com.wafflestudio.snutt.coursebook.data.CoursebookDto
import com.wafflestudio.snutt.coursebook.service.CoursebookService
import com.wafflestudio.snutt.evaluation.service.EvService
Expand Down Expand Up @@ -326,7 +325,7 @@ class TimetableServiceImpl(
timetableId: String,
) {
val table = timetableRepository.findById(timetableId) ?: throw TimetableNotFoundException
if (table.isPrimary != true) throw TimetableNotPrimaryException
if (table.isPrimary != true) return
timetableRepository.save(table.copy(isPrimary = false))
}

Expand Down
Loading