Skip to content

Update EnsureCSPDoesNotBlockStringCompilation to match updated HostEnsureCanCompileStrings definition #650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
annevk merged 5 commits into from
Jun 13, 2024
Merged

Update EnsureCSPDoesNotBlockStringCompilation to match updated HostEnsureCanCompileStrings definition #650

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
961e959
Update EnsureCSPDoesNotBlockStringCompilation to match updated HostEn…
lukewarlow Mar 14, 2024
e0e7778
Re-add |source|
lukewarlow Apr 23, 2024
76997e0
Update |source| to |codeString|
lukewarlow Jun 11, 2024
bef0e49
Fix build error
lukewarlow Jun 13, 2024
a078c7f
Add missing compilationType from unused note
lukewarlow Jun 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions index.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1442,10 +1442,11 @@ spec: WebRTC; urlPrefix: https://www.w3.org/TR/webrtc/
to determine whether such compilation ought to be blocked.

<h4 id="can-compile-strings" algorithm dfn export>
EnsureCSPDoesNotBlockStringCompilation(|realm|, |source|)
EnsureCSPDoesNotBlockStringCompilation(|realm|, |parameterStrings|, |bodyString|, |source|, |compilationType|, |parameterArgs|, |bodyArg|)
</h4>

Given a <a>realm</a> |realm| and a string |source|, this algorithm
Given a <a>realm</a> |realm|, a list of strings |parameterStrings|, a string |bodyString|, a string |source|, an enum (|compilationType|),
a list of ECMAScript language values (|parameterArgs|), and an ECMAScript language value (|bodyArg|), this algorithm
returns normally if string compilation is allowed, and throws an "`EvalError`"
if not:

Expand Down Expand Up @@ -1483,9 +1484,7 @@ spec: WebRTC; urlPrefix: https://www.w3.org/TR/webrtc/

4. If |result| is "`Blocked`", throw an `EvalError` exception.

ISSUE(tc39/ecma262#938): {{HostEnsureCanCompileStrings()}} does not include the string which is
going to be compiled as a parameter. We'll also need to update HTML to pipe that value through
to CSP.
Note: |parameterStrings|, |parameterArgs|, |bodyArg| and |bodyString| are currently unused. They are included for future use.
Copy link
Copy Markdown
Member

@annevk annevk Jun 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

parameterStrings, codeString, compilationType, parameterArgs, and bodyArg are currently unused. Right?

Copy link
Copy Markdown
Member Author

@lukewarlow lukewarlow Jun 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

codeString is used but compilationType isn't I've updated that.


<h3 id="wasm-integration">Integration with WebAssembly</h3>

Expand Down