Simplifying functional event handling#305
Conversation
|
This can merge now btw. Anyone more familiar with the spec able to handle the conflicts? |
| </dd> | ||
| <dt><a data-lt= | ||
| "PaymentRequestEvent.paymentRequestId">paymentRequestId</a></dt> | ||
| <dd>The [[\details]].<a>id</a> from the <a>PaymentRequest</a></dd> |
There was a problem hiding this comment.
Bad merge: please remove paymentRequestId from CanMakePaymentEvent.
| </dt> | ||
| <dd>The result of executing the <a>MethodData Population | ||
| Algorithm</a></dd> | ||
| <dt><a data-lt="PaymentRequestEvent.modifiers">modifiers</a> |
There was a problem hiding this comment.
Bad merge: please remove modifiers from CanMakePaymentEvent.
| </dt> | ||
| <dd>The result of executing the <a>Modifiers Population | ||
| Algorithm</a></dd> | ||
| <dt><a data-lt="PaymentRequestEvent.total">total</a> |
There was a problem hiding this comment.
Bad merge: please remove total from CanMakePaymentEvent.
| <dd>A <a>structured clone</a> of the total field on the | ||
| <a>PaymentDetailsInit</a> from the corresponding | ||
| <a>PaymentRequest</a>.</dd> | ||
| <dt><a data-lt= |
There was a problem hiding this comment.
Bad merge: please remove instrumentKey from CanMakePaymentEvent.
rsolomakhin
left a comment
rsolomakhin
left a comment
There was a problem hiding this comment.
Thank you for the pull request! Please remove the extra fields that I pointed out from CanMakePaymentEvent.
|
@jakearchibald : Could you resolve conflicts so we can merge this, please? Thank you. |
|
(If you don't have time, we can do it.) |
|
On travels right now. Gimmie a week 😄. |
We should do it. Let poor Jake have a holiday :) |
|
May be superseded by |
* Removed conflicts between gh-pages and #305 * updated per Rouslan request * rouslan's fixes
|
Hi @jakearchibald, closing this pull request. Thank you for doing it. With Rouslan we made your changes with a newer version of the spec: |
5 participants
I've simplified event firing as part of w3c/ServiceWorker#1199.
Don't merge this until w3c/ServiceWorker#1199 merges, but you can review now.
Preview | Diff