Update handling of timer functions#481
Merged
lukewarlow merged 3 commits intow3c:mainfrom Mar 27, 2024
Merged
Conversation
lukewarlow
commented
Mar 14, 2024
| * |sink| set to `Window setInterval` if <var ignore>repeat</var> is true, `Window setTimeout` otherwise. | ||
| * |sinkGroup| set to `'script'`. | ||
|
|
||
| Note: This matches the logic that the extended attribute would apply. |
Member
Author
There was a problem hiding this comment.
We use the string context here, so no need to do any of this block.
lukewarlow
commented
Mar 14, 2024
Member
Author
|
@otherdaniel you implemented this functionality in Chromium iirc would you be able to take a quick look over this PR to sanity check it? |
ghost
reviewed
Mar 26, 2024
ghost
reviewed
Mar 26, 2024
otherdaniel
reviewed
Mar 26, 2024
Member
otherdaniel
left a comment
otherdaniel
left a comment
There was a problem hiding this comment.
Thank you. Generally, this looks exactly right to me!
There's one editorial nitpick with the note.
The other issue is about the definition of |compilationType|, where I might well be overlooking something. Would be good to get that resolved.
ghost
reviewed
Mar 27, 2024
ghost
reviewed
Mar 27, 2024
Member
Author
|
Based on @otherdaniel review I'm going to go ahead and merge this |
github-actions Bot
added a commit
that referenced
this pull request
Mar 27, 2024
SHA: 39cc82e Reason: push, by lukewarlow Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #480
This effectively follows the Chromium implementation, we use the StringContext attribute to do the enforcement for setTimeout and setInterval and then update the
HostEnsureCanCompileStringscall (which now actually calls the CSP function directly) accordingly.We then update
EnsureCSPDoesNotBlockStringCompilationto only do TT validation for eval and Function, not timers.Preview | Diff