Push subscriptions are not associated with service workers#388
Merged
Push subscriptions are not associated with service workers#388
Conversation
saschanaz
reviewed
Sep 3, 2024
Member
saschanaz
left a comment
saschanaz
left a comment
There was a problem hiding this comment.
LGTM but maybe @asutherland want to double check?
That said I think Gecko still maps push with the SW scope instead of each registration: https://searchfox.org/mozilla-central/rev/aee7c3a0dbf33af0c4f6648f391db62b35895e50/dom/push/PushManager.cpp#506 (which we want to fix)
asutherland
approved these changes
Sep 3, 2024
asutherland
left a comment
asutherland
left a comment
There was a problem hiding this comment.
Yeah, the coupling to ServiceWorker here seems like it was in error regardless of what we do as a result of #368.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #384.
Preview | Diff