Editorial: Introduce 'push subscription owner' concept#367
Closed
marcoscaceres wants to merge 1 commit intogh-pagesfrom
Closed
Editorial: Introduce 'push subscription owner' concept#367marcoscaceres wants to merge 1 commit intogh-pagesfrom
marcoscaceres wants to merge 1 commit intogh-pagesfrom
Conversation
Comment on lines
+182
to
+183
| Future updates to this specification could expand the definition of a [=push subscription | ||
| owner=] to include other types, broadening the range of possible implementations. |
Member
There was a problem hiding this comment.
I'd like to see that future update before adding another layer of indirection. Do you have something more concrete to share?
Member
Author
There was a problem hiding this comment.
Yes, I can send the larger PR... thought I'd start small and build it up, but happy to just send the larger change that separates between service worker and using window.navigator.pushManager.
Member
Author
|
closing in favor or #368 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #360
We propose adding 'push subscription owner' concept, to allow a Window to eventually also be the owner of a push subscription (not just a service worker).
This makes no substantive changes at this point... just lays down infrastructure that we can then use for branching.
Preview | Diff