Add MediaTranscripts to MediaMetadata (#370)#371
Open
yrw-google wants to merge 2 commits intow3c:mainfrom
Open
Add MediaTranscripts to MediaMetadata (#370)#371yrw-google wants to merge 2 commits intow3c:mainfrom
yrw-google wants to merge 2 commits intow3c:mainfrom
Conversation
domfarolino
reviewed
Mar 26, 2026
domfarolino
reviewed
Apr 4, 2026
Member
domfarolino
left a comment
domfarolino
left a comment
There was a problem hiding this comment.
Please find other instances of "should" that are in descriptive documentation of things enforced by Web IDL, and incorporate them.
domfarolino
reviewed
Apr 4, 2026
Member
domfarolino
left a comment
domfarolino
left a comment
There was a problem hiding this comment.
I think the last thing that stands out to me is instances of "MUST" and "SHOULD" should be "must" and "should", without the capitalization, per ordinary WHATWG/W3C spec conventions.
Author
I've updated the "must" added in this PR to be uncapitalized, but the other instances are out of scope for this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the MediaTranscripts and MediaTranscript interfaces in order to add a list of MediaTranscripts to MediaMetadata, which allows sites to provide high-quality transcripts as described in #370.
Preview | Diff