Skip to content

Allow for overriding reasons tracks stay muted#335

Open
jan-ivar wants to merge 1 commit intow3c:mainfrom
jan-ivar:uncheckmuteall
Open

Allow for overriding reasons tracks stay muted#335
jan-ivar wants to merge 1 commit intow3c:mainfrom
jan-ivar:uncheckmuteall

Conversation

@jan-ivar
Copy link
Copy Markdown
Member

@jan-ivar jan-ivar commented Jul 12, 2024

Fixes #332 (also renames a variable to improve clarity). cc @youennf PTAL.


Preview | Diff

Comment thread index.bs
<ol>
<li>
Provided <var>track</var> is not [=MediaStreamTrack/muted=]
by the user agent for reasons that override its [=pausing all
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this case, we might be again in capture state UI out of sync with the device mute state.
It seems to me that, in the usual case of capturing with only one device, UA should instead deny the request.

It is really only when there are multiple capture devices that is fine to do what you are suggesting (In that case the capture state UI will also be in sync since at least one device will restart capture).

It seems a note for implementors stating the reasons to override and/or deny might be helpful.

@youennf
Copy link
Copy Markdown
Contributor

youennf commented Jan 20, 2025

@jan-ivar, do you plan to move forward with this PR?

@marcoscaceres marcoscaceres requested a review from Copilot August 21, 2025 11:36
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses issue #332 by allowing user agents to override the media session's pausing policy when tracks are muted for other reasons. The change ensures that tracks muted by external factors (like hardware mute buttons) are not affected by the session's pause/resume behavior.

  • Renames applyPausePolicy variable to implementPausePolicy for clarity
  • Adds conditional logic to prevent overriding track muted states when tracks are already muted for reasons beyond the pausing policy
  • Includes explanatory note about overriding reasons such as physical mute buttons

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread index.bs
<li>
Provided <var>track</var> is not [=MediaStreamTrack/muted=]
by the user agent for reasons that override its [=pausing all
input sources | pausing policy=],
Copy link

Copilot AI Aug 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reference '[=pausing all input sources | pausing policy=]' appears to have inconsistent linking syntax. Consider using consistent reference formatting throughout the specification.

Suggested change
input sources | pausing policy=],
by the user agent for reasons that override its [=pausing all input sources=],

Copilot uses AI. Check for mistakes.
@marcoscaceres
Copy link
Copy Markdown
Member

@jan-ivar, is this still something worth integrating? If yes, rebase please? 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The update capture state algorithm needs refinement

4 participants