Rename "default display mode" to "applied display mode"#1215
Rename "default display mode" to "applied display mode"#1215marcoscaceres wants to merge 4 commits intomainfrom
Conversation
Closes #1024. The term "default" implied a fallback, when it actually meant the display mode currently in effect. This rename clarifies the three roles: the manifest declares a preferred display mode, the UA determines the applied display mode, and the display-mode media feature reflects the applied one. Also fixes the [=applies=] link so the subject is the manifest (matching the dfn at #applying), and corrects the security example from "another origin" to "out of scope" for consistency with the rest of the spec.
marcoscaceres
requested review from
christianliebel,
Copilot,
dmurph and
saschanaz
There was a problem hiding this comment.
Pull request overview
Renames the spec term “default display mode” to “applied display mode” to better reflect that it’s the display mode currently in effect after UA choice/overrides.
Changes:
- Replaces “default display mode” with “applied display mode” in the display mode section.
- Updates related prose around manifest application and security override example wording.
- Tweaks the
display-modemedia feature sentence to reference the new term.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
christianliebel
left a comment
christianliebel
left a comment
There was a problem hiding this comment.
This is different now from what @dmurph suggested, but it would work for me as well.
|
@dmurph, do you want to give this another look? |
| another origin) and/or the user agent MAY provide the user with a means | ||
| of switching to another <a>display mode</a>. | ||
| Once a manifest is [=applied=] to a <a>top-level browsing context</a>, | ||
| the resulting <a>display mode</a> becomes the <dfn>applied display |
There was a problem hiding this comment.
result becomes the result? maybe "resulting display mode is referred as" or something like it?
- Remove tautology: "resulting X becomes X" → "X in effect is the" - Remove redundant parenthetical that restated the definition - "MAY override" → "MAY change" (override conflicts with "applied" semantics) - Use defined term in note: "actual display mode being applied" → linked term
Convert <a>display mode</a> and <a>applied display mode</a> to [=display mode=] and [=applied display mode=] shorthand, consistent with the rest of the spec's linking style.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| </p> | ||
| <p> | ||
| A user agent MUST reflect the applied <a>display mode</a> of the web | ||
| A user agent MUST reflect the <a>applied display mode</a> of the web |
There was a problem hiding this comment.
This now conflicts with the previous statement - a user agent can override it and then here it says it must reflect it. Should this be lifted?
Closes #1024
This change (choose at least one, delete ones that don't apply):
Commit message:
editorial: rename "default display mode" to "applied display mode"
The term "default" implied a fallback, when it actually meant the display mode
currently in effect. This rename clarifies the three roles: the manifest's
displaymember declares the preferred display mode, the UA determines theapplied display mode (via the fallback chain and user/UA overrides), and the
display-modemedia feature reflects the applied one.Also fixes the
[=applies=]cross-reference so the subject is the manifest(matching the dfn at #applying), and corrects the security override example
from "another origin" to "out of scope" for consistency with the rest of the
spec.
Preview | Diff