-
Notifications
You must be signed in to change notification settings - Fork 180
Clarify how manifest image resources are fetched #1171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
marcoscaceres
wants to merge
10
commits into
main
Choose a base branch
from
sub-resource
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 9 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
a987d3f
Clarify how manifest image resources are fetched
marcoscaceres 30a8bdb
Update index.html
marcoscaceres 2ef288f
Fix typos and restore CSP example in manifest image resources section
marcoscaceres a00c2fc
Add client parameter and fetch algorithm for manifest image resources
marcoscaceres d73ab82
Clarify client parameter in HTML invocation context
marcoscaceres f2767e8
Fix ReSpec markup in fetch algorithm
marcoscaceres a1a3f2d
Add note explaining why image fetch is skipped when client is null
marcoscaceres 6ec4eb6
Add note on when to call fetch a manifest image resource; fix |client…
marcoscaceres 43baafd
Return null explicitly when client is null
marcoscaceres bbce97e
Declare return type in fetch a manifest image resource signature
marcoscaceres File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.