Update interface for install event in summary table#1706
Merged
mkruisselbrink merged 1 commit intow3c:mainfrom Feb 22, 2024
Merged
Update interface for install event in summary table#1706mkruisselbrink merged 1 commit intow3c:mainfrom
mkruisselbrink merged 1 commit intow3c:mainfrom
Conversation
Following w3c#1701, the `install` event now uses the `InstallEvent` interface.
tidoust
added a commit
to w3c/webref
that referenced
this pull request
Feb 22, 2024
Pending w3c/ServiceWorker#1706. Our consistency tests fail otherwise because it cannot link the new `InstallEvent` interface to any event.
tidoust
added a commit
to w3c/webref
that referenced
this pull request
Feb 22, 2024
Pending w3c/ServiceWorker#1706. Our consistency tests fail otherwise because it cannot link the new `InstallEvent` interface to any event.
mkruisselbrink
approved these changes
Feb 22, 2024
Collaborator
mkruisselbrink
left a comment
mkruisselbrink
left a comment
There was a problem hiding this comment.
Thanks for the fix. Yeah, the other paragraph could probably use some cleanup/removal as well although as you say it's not entirely wrong...
github-actions Bot
added a commit
that referenced
this pull request
Feb 22, 2024
SHA: 613f5a2 Reason: push, by mkruisselbrink Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions Bot
added a commit
to asleekgeek/ServiceWorker
that referenced
this pull request
Feb 23, 2024
SHA: 613f5a2 Reason: push, by pull[bot] Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following #1701, the
installevent now uses theInstallEventinterface.(FWIW, I noticed that because our spec crawler parses that table to map events with interfaces and make sure that everything's consistent)
I note that the spec also says in section 4.4:
That's not completely wrong since
InstallEventinherits fromExtendableEvent, but maybe worth updating as well? The whole paragraph could perhaps be dropped since it does not really add new information: lifecycle events are already defined elsewhere, and the interface used is defined in algorithms (and summarized in the events table).Preview | Diff