ddclient: T6981: Upgrade ddclient to v4.0.0#5123
Open
indrajitr wants to merge 15 commits intovyos:currentfrom
Open
ddclient: T6981: Upgrade ddclient to v4.0.0#5123indrajitr wants to merge 15 commits intovyos:currentfrom
indrajitr wants to merge 15 commits intovyos:currentfrom
Conversation
In ddclient v4, tls (ssl) is enabled by default, there is no need to set it up explicitly in the configuration file.
Since googledomains (domains.google.com) has been shut down, we need to remove any configuration path that refers to googledomains. 1. Remove 'googledomains' as the default web resolver in ddclient.conf.j2 2. Apply migration to remove googledomains from dynamic DNS service configurations. The migration is also necessary to undo a previous migration where we added 'googledomains' as default web resolver to work around lack of tls (ssl) support with default web resolver 'dyndns' (checkip.dyndns.org) in ddclient v3.x.
|
👍 |
|
All contributors have signed the CLA ✍️ ✅ |
11 tasks
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
Update smoketests for dual stack configuration. Also replace 'googledomains' with 'changeip' in smoketests since googledomains (domains.google.com) has been shut down.
Since woima (woima.fi) has been shut down, we need to remove any configuration path that refers to woima. Apply migration to remove woima from dynamic DNS service configurations.
In ddclient v4, there is no need to warn for the usage of checkip.dyndns.org even if it does not support http over tls. This is because the protocol specifier (http://) is honored even when tls (ssl) is enabled.
In ddclient v4, 'use' is not a global scope property anymore. Besides 'use' had been deprecated in favor of 'usev4'/'usev6' in ddclient v3.10.
In ddclient v4, the 'ip' and 'status' fields are no longer supported. They were used to store IPv4 addresses and their status in a backward compatible way in ddclient v3.
Protocol 'nsupdate' (rfc2136) now supports dual-stack
('usev4', 'usev6' options), so there is no need for
special treatment for 'nsupdate' in the config template.
Relocate key mapping for 'nsupdate' (rfc2136) from Jinja template to Python. This keeps the template simpler and allows for more complex dict handling in Python.
In ddclient v4, some new supported protocols, viz., directnic, emailonly have configuration that cannot be supported in current VyOS config mode yet.
These new protocols are supported in ddclient v4: 'ddns.fm', 'he.net', 'inwx' These existing protocols gained dual stack support in ddclient v4: 'domeneshop', 'gandi', 'godaddy', 'mythicdyn', 'noip', 'nsupdate', 'regfishde'
Add `app.luadns.com` and `update.dedyn.io` to allow-list for dualstack support using 'dyndns2' protocol since they have been reported to work as expected.
In ddclient, 'porkbun' protocol uses properties that are different from the ones used by VyOS configuration. Support for 'porkbun' is enabled by adding the necessary property remaping before applying them to the template to render the final ddclient config.
Since the API key has been deprecated by Gandi, enforce using personal access token for 'gandi' protocol.
|
CI integration ❌ failed! Details
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change summary
Upgrade ddclient to version 4.0.0
ddclient 4.0 brings quite a few changes. Significant ones in the context of VyOS are:
googledomainsandwoimahave been removed since those services are defunctwebv4/webv6finally supports tls)domeneshop,gandi,godaddy,mythicdyn,noip,nsupdate,regfishde,luadns)ddns.fm,he.net,inwx,porkbun)gandisupports personal access token only)See: https://github.com/ddclient/ddclient/blob/main/ChangeLog.md#2025-01-19-v400 for upstream changelog.
Note: We used
googedomainsas default to detect IP address overwebv4/webv6in the past. Sincegoogedomainsis not available anymore, we have a migration script to adjust the legacy configuration.Types of changes
Related Task(s)
Related PR(s)
vyos/vyos-build/pull/1159
How to test / Smoketest result
Checklist: