fix: fix injection symbol(clientData) failure caused by HMR, close #1715#1716
Open
pengzhanbo wants to merge 1 commit into
Open
fix: fix injection symbol(clientData) failure caused by HMR, close #1715#1716pengzhanbo wants to merge 1 commit into
symbol(clientData) failure caused by HMR, close #1715#1716pengzhanbo wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before submitting the PR, please make sure you do the following
close #123).What is the purpose of this pull request?
Description
resolve #1715.
From a shallow analysis, this is a bug caused by the module-level constant
symbol('clientData')being replaced with a new constant during hot updates.This PR can fix the issue.
However, the deeper reason is that every time markdown is updated, two
import.meta.hot.acceptcallbacks are triggered. In these callbacks, the component chunk returns a new object (a new component) each time, and one is asynchronous while the other is synchronous:reloadorrerenderupdatePageDataInternally, there is a race condition rewriting of the hot-updated components between these two, and the problem may have started from this point.
Regarding the hot-update issue from markdown to Vue, I believe it is necessary to rewrite it appropriately to fundamentally solve such problems.
Screenshots
Before
After