Repository navigation
Add pr options to msync execute - #384
Merged
Merged
Conversation
Contributor
Author
|
Working example can be found at: Joris29/puppet-rundeck#1 |
marcusdots
approved these changes
Oct 26, 2026
marcusdots
left a comment
There was a problem hiding this comment.
I think the idea is awesome. I recommend to fix rubocop and continue with this idea.
Joris29
force-pushed
the
msync_exec_git
branch
2 times, most recently
from
October 27, 2026 13:18
3b79f84 to
882be9d
Compare
Joris29
marked this pull request as ready for review
October 27, 2026 13:33
marcusdots
requested changes
Oct 27, 2026
marcusdots
left a comment
There was a problem hiding this comment.
Could you please fix the scope with a solution of your liking and I will approve this PR?
|
I would like to add one request:
gets satisfied? |
Joris29
force-pushed
the
msync_exec_git
branch
4 times, most recently
from
November 3, 2026 13:27
d7defe9 to
96e9c7d
Compare
marcusdots
approved these changes
Nov 3, 2026
Joris29
force-pushed
the
msync_exec_git
branch
2 times, most recently
from
November 3, 2026 15:42
ec4d8df to
d360368
Compare
Joris29
force-pushed
the
msync_exec_git
branch
from
November 3, 2026 15:48
d360368 to
6ae5560
Compare
Member
|
@Joris29 your commits are still not signed with a gpg or ssh key. Can you please do that? |
Joris29
force-pushed
the
msync_exec_git
branch
2 times, most recently
from
November 3, 2026 17:47
ca7c933 to
0aae25e
Compare
Signed-off-by: Joris29 <joris.vanacoleyen@bryxx.eu>
Joris29
force-pushed
the
msync_exec_git
branch
from
November 3, 2026 18:04
0aae25e to
8aaf77b
Compare
Contributor
Author
|
Got it signed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.