Skip to content

lib: add file locking to downloads #675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Duncaen wants to merge 2 commits into
base: master
Choose a base branch
from

tests: rewrite xbps-fetch tests to use atf_check

328f569
Select commit
Loading
Failed to load commit list.
Open

lib: add file locking to downloads #675

tests: rewrite xbps-fetch tests to use atf_check
328f569
Select commit
Loading
Failed to load commit list.
GitHub Advanced Security / CodeQL failed Feb 17, 2026 in 2s

1 new alert including 1 high severity security vulnerability

New alerts in code changed by this pull request

Security Alerts:

  • 1 high

See annotations below for details.

View all branch alerts.

Annotations

Check failure on line 221 in lib/download.c

See this annotation in the file changed.

Code scanning / CodeQL

Time-of-check time-of-use filesystem race condition High

The
filename
Loading
being operated upon was previously
checked
Loading
, but the underlying file may have been changed since then.
The
filename
Loading
being operated upon was previously
checked
Loading
, but the underlying file may have been changed since then.

Check warning on line 392 in lib/download.c

See this annotation in the file changed.

Code scanning / CodeQL

Comparison result is always the same Warning

Comparison is always true because lockfd >= 0.