Skip to content

Don't leave orphaned file after removing a disk #743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Hi-Angel wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Don't leave orphaned file after removing a disk #743

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eee1a18
delete_disk_from_vm.py: tell exact disk name that will be removed
Hi-Angel Jan 19, 2024
bac9398
delete_disk_from_vm.py: don't leave an orphaned file
Hi-Angel Jan 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions samples/delete_disk_from_vm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,9 @@ def delete_virtual_disk(si, vm_obj, disk_number, language):
virtual_hdd_spec = vim.vm.device.VirtualDeviceSpec()
virtual_hdd_spec.operation = \
vim.vm.device.VirtualDeviceSpec.Operation.remove
# remove the file that was used by disk as well
virtual_hdd_spec.fileOperation = \
vim.vm.device.VirtualDeviceSpec.FileOperation.destroy
virtual_hdd_spec.device = virtual_hdd_device

spec = vim.vm.ConfigSpec()
Expand All @@ -79,9 +82,7 @@ def main():

if vm_obj:
if not args.yes:
cli.prompt_y_n_question("Are you sure you want "
"to delete HDD "
"{}?".format(args.unitnumber),
cli.prompt_y_n_question(f'Are you sure you want to delete "Hard Disk {args.unitnumber}" and its file?',
default='no')
delete_virtual_disk(si, vm_obj, args.unitnumber, args.language)
print('VM HDD "{}" successfully deleted.'.format(args.unitnumber))
Expand Down