Skip to content

Fixed Clone VM sample which constructs invalid Clonespec when making default choice for missing parameters #610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kumahesh wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixed Clone VM sample which constructs invalid Clonespec when making default choice for missing parameters #610

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
85 changes: 52 additions & 33 deletions samples/clone_vm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,10 @@
from add_nic_to_vm import add_nic


SUCCESS = True
FAILURE = False


def get_args():
""" Get arguments from CLI """
parser = argparse.ArgumentParser(
Expand Down Expand Up @@ -84,8 +88,9 @@ def get_args():
required=False,
action='store',
default=None,
help='Datastorecluster (DRS Storagepod) you wish the VM to end up on \
Will override the datastore-name parameter.')
help='Datastorecluster (DRS Storagepod) you wish '
'the VM to end up on Will override the '
'datastore-name parameter.')

parser.add_argument('--cluster-name',
required=False,
Expand Down Expand Up @@ -122,24 +127,27 @@ def get_args():

def wait_for_task(task):
""" wait for a vCenter task to finish """
task_done = False
while not task_done:
while True:
if task.info.state == 'success':
return task.info.result

if task.info.state == 'error':
print("there was an error")
task_done = True
return FAILURE


def get_obj(content, vimtype, name):
def get_obj(content, vimtype, name, datacenter=None):
"""
Return an object by name, if name is None the
first found object is returned
"""
obj = None
container = content.viewManager.CreateContainerView(
content.rootFolder, vimtype, True)
if datacenter is None:
container = content.viewManager.CreateContainerView(
content.rootFolder, vimtype, True)
else:
container = content.viewManager.CreateContainerView(
datacenter, vimtype, True)
for c in container.view:
if name:
if c.name == name:
Expand All @@ -153,9 +161,9 @@ def get_obj(content, vimtype, name):


def clone_vm(
content, template, vm_name, si,
datacenter_name, vm_folder, datastore_name,
cluster_name, resource_pool, power_on, datastorecluster_name):
content, template, vm_name,
datacenter_name, vm_folder_name, datastore_name,
cluster_name, resource_pool_name, power_on, datastorecluster_name):
"""
Clone a VM from a template/VM, datacenter_name, vm_folder, datastore_name
cluster_name, resource_pool, and power_on are all optional.
Expand All @@ -164,30 +172,34 @@ def clone_vm(
# if none git the first one
datacenter = get_obj(content, [vim.Datacenter], datacenter_name)

if vm_folder:
destfolder = get_obj(content, [vim.Folder], vm_folder)
if vm_folder_name:
destfolder = get_obj(content, [vim.Folder], vm_folder_name,
datacenter=datacenter)
else:
destfolder = datacenter.vmFolder

if datastore_name:
datastore = get_obj(content, [vim.Datastore], datastore_name)
else:
datastore = get_obj(
content, [vim.Datastore], template.datastore[0].info.name)

# if None, get the first one
cluster = get_obj(content, [vim.ClusterComputeResource], cluster_name)

if resource_pool:
resource_pool = get_obj(content, [vim.ResourcePool], resource_pool)
else:
cluster = get_obj(content, [vim.ClusterComputeResource], cluster_name,
datacenter=datacenter)

resource_pool = None
if resource_pool_name:
resource_pool = get_obj(content, [vim.ResourcePool],
resource_pool_name,
datacenter=datacenter)
elif cluster: # if cluster is not none, take it from there
resource_pool = cluster.resourcePool

if resource_pool is None:
print("Not able to find resource pool for cloning VM")
return FAILURE

vmconf = vim.vm.ConfigSpec()

if datastorecluster_name:
podsel = vim.storageDrs.PodSelectionSpec()
pod = get_obj(content, [vim.StoragePod], datastorecluster_name)
pod = get_obj(content, [vim.StoragePod], datastorecluster_name,
datacenter=datacenter)
podsel.storagePod = pod

storagespec = vim.storageDrs.StoragePlacementSpec()
Expand All @@ -202,10 +214,19 @@ def clone_vm(
storageSpec=storagespec)
rec_action = rec.recommendations[0].action[0]
real_datastore_name = rec_action.destination.name
except:
except Exception:
real_datastore_name = template.datastore[0].info.name

datastore = get_obj(content, [vim.Datastore], real_datastore_name)
elif datastore_name:
real_datastore_name = datastore_name
else:
real_datastore_name = template.datastore[0].info.name

datastore = get_obj(content, [vim.Datastore], real_datastore_name,
datacenter=datacenter)
if datastore is None:
print("Not able to find datastore for cloning vm")
return FAILURE

# set relospec
relospec = vim.vm.RelocateSpec()
Expand All @@ -218,7 +239,7 @@ def clone_vm(

print("cloning VM...")
task = template.Clone(folder=destfolder, name=vm_name, spec=clonespec)
wait_for_task(task)
return wait_for_task(task)


def main():
Expand All @@ -228,7 +249,6 @@ def main():
args = get_args()

# connect this thing
si = None
if args.no_ssl:
si = SmartConnectNoSSL(
host=args.host,
Expand All @@ -245,17 +265,16 @@ def main():
atexit.register(Disconnect, si)

content = si.RetrieveContent()
template = None

template = get_obj(content, [vim.VirtualMachine], args.template)

if template:
clone_vm(
content, template, args.vm_name, si,
status = clone_vm(
content, template, args.vm_name,
args.datacenter_name, args.vm_folder,
args.datastore_name, args.cluster_name,
args.resource_pool, args.power_on, args.datastorecluster_name)
if args.opaque_network:
if status and args.opaque_network:
vm = get_obj(content, [vim.VirtualMachine], args.vm_name)
add_nic(si, vm, args.opaque_network)
else:
Expand Down