[Bugfix] Fix VLLM_ENFORCE_STRICT_TOOL_CALLING mutation in tests - #49846
Merged
sfeng33 merged 2 commits intoJul 27, 2026
Conversation
Signed-off-by: Yifan Zong <yzong@redhat.com>
yzong-rh
changed the title
Contributor
Author
yzong-rh
marked this pull request as ready for review
July 25, 2026 23:53
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
sfeng33
approved these changes
Jul 27, 2026
sfeng33
enabled auto-merge (squash)
July 27, 2026 14:56
github-actions
Bot
added
the
ready
edwinlim0919
pushed a commit
to chaeminlim-mb/vllm
that referenced
this pull request
Jul 29, 2026
…-project#49846) Signed-off-by: Yifan Zong <yzong@redhat.com>
aoshen02
pushed a commit
to zllion/vllm
that referenced
this pull request
Aug 1, 2026
…-project#49846) Signed-off-by: Yifan Zong <yzong@redhat.com> Signed-off-by: aoshen02 <aoshen@inferact.ai>
pranavthakur0-0
pushed a commit
to pranavthakur0-0/vllm
that referenced
this pull request
Aug 4, 2026
…-project#49846) Signed-off-by: Yifan Zong <yzong@redhat.com>
itej89
pushed a commit
to itej89/vllm
that referenced
this pull request
Aug 4, 2026
…-project#49846) Signed-off-by: Yifan Zong <yzong@redhat.com> Signed-off-by: Tej Kiran <kiran.tej@amd.com>
aditi-amd
pushed a commit
to aditi-amd/vllm
that referenced
this pull request
Aug 4, 2026
…-project#49846) Signed-off-by: Yifan Zong <yzong@redhat.com> Signed-off-by: root <root@smci355-ccs-aus-m02-09.cs-aus.dcgpu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Fix a code smell / latent bug where tests sets env variable VLLM_ENFORCE_STRICT_TOOL_CALLING=0, potentially leading to tests assuming VLLM_ENFORCE_STRICT_TOOL_CALLING=1 to fail.
Occurred for #45560.
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.