resolves #668#673
Open
ymajoros wants to merge 1 commit intovladmihalcea:masterfrom
Open
Conversation
Author
|
#675 actually solves it in a better way. They could still be split in 2, but I think it's not worth it, as further refactorings were needed. |
Owner
|
@ymajoros Why make all these changes instead of just doing this instead? |
ymajoros
pushed a commit
to ymajoros/hypersistence-utils
that referenced
this pull request
Nov 13, 2023
Author
|
@vladmihalcea this seems to indeed simplify it. I updated #675 with that, as it was needed there as well. |
vladmihalcea
force-pushed
the
master
branch
7 times, most recently
from
8f9b861 to
57d78d6
Compare
vladmihalcea
force-pushed
the
master
branch
5 times, most recently
from
a901c16 to
733fdde
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.