Open
Conversation
vladmihalcea
force-pushed
the
master
branch
2 times, most recently
from
aff9872 to
b7efcfb
Compare
vladmihalcea
force-pushed
the
master
branch
7 times, most recently
from
8f9b861 to
57d78d6
Compare
vladmihalcea
force-pushed
the
master
branch
5 times, most recently
from
a901c16 to
733fdde
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
i added 3 tests to show that the closed method for the upper bound is never correctly setting the bound as closed. it is always saving it as open. however the lower bound is working as expected. 2 of the 3 tests are failing