Repository navigation
Add playlists and a one-feature-per-PR Jellyfin parity backlog - #38
Conversation
Accounts can create named playlists, add films and shows from their detail pages, reorder or remove items, and keep child-account rating caps enforced. The parity document lists each remaining Jellyfin feature with its own scope and proposed PR order. 🤖 Generated with Codebuff Co-Authored-By: Codebuff <noreply@codebuff.com>
The README rewrite moved features and setup into new sections, and this branch had added its feature block inside what upstream now uses for the services table. The merge keeps upstream's structure, folds the playlists feature into the features list, and links the parity backlog from Contributing. 🤖 Generated with Codebuff Co-Authored-By: Codebuff <noreply@codebuff.com>
|
@vitobotta ready for a first review and mergeable against current |
vitobotta
left a comment
There was a problem hiding this comment.
First review at c1e5e69, with main merged. The suite is green: 515 examples, 0 failures, and RuboCop is clean on the twelve touched Ruby files, so the note in the description about a missing toolchain is the only reason these were not run before opening. I also checked what the specs do not cover: a child account sees the allowed items and the hidden count, another account gets a redirect with no playlist data, a metadata failure still renders the content page, and both pages hold at 1280 and at phone width.
One blocking problem: adding a show from its detail page cannot succeed, because of the year format. Details on the line below.
The minor items are on the lines below as well: two rows in the parity table are stale, the index count includes hidden items, the reorder arrows are computed from the filtered list, and an unknown move direction is treated as down. The feature is otherwise sound: ownership scoping, the duplicate rule and position ordering all behave.
…lists A show could never be added from its detail page because Cinemeta reports a year range and numericality validates the raw value; the index also promised titles the playlist page hides, arrows were indexed against the filtered list, and any direction string reordered the playlist.
|
@vitobotta all five are addressed on the branch.
|
vitobotta
left a comment
There was a problem hiding this comment.
Re-reviewed at 6ab56894. The five findings from the first pass are addressed:
- Series year:
normalize_yearkeeps the first four-digit year before numericality; the new request example posts2008-2013and stores 2008. - Hidden counts: the index now shows the visible count plus the hidden count for the account; the new example asserts both.
- Arrows:
@ordered_idscomes from the full ordered playlist, so the move boundaries matchPlaylistItem#move!. - Invalid direction:
moveaccepts onlyupanddownand redirects with an alert; the new example checks the order is unchanged. - Docs: rows 34 and 58 now match the code.
One new blocking regression on the create failure path, plus one minor note, both on the lines below.
Gates at the head: playlists 14/0, full suite 518/0 (excluding my throwaway probe), JS 528/0, RuboCop clean on the four touched Ruby files.
…eal years The index view ran with nil counts when create re-rendered it for an account that already had playlists, and the year helper turned 20100 into 2010 instead of leaving malformed input to validation.
|
@vitobotta both fixed at
|
vitobotta
left a comment
There was a problem hiding this comment.
Both open findings are fixed at 3bfc659.
The create failure path now builds the same counts as index through build_item_counts, and the new request example covers an account with an existing playlist. The year normalizer now accepts one four-digit year or a range of two and leaves other input to numericality. A probe confirmed 20100 stays 20100 and fails validation, while a spaced two-year range stores 2008.
The branch merges cleanly with main at 97f9ddf. Gates on the merged tree: 554 RSpec examples, 0 failures; 578 JavaScript tests, 0 failures; RuboCop 185 files, no offenses; Brakeman clean.
No new findings.
|
Merged. Thanks @phantomic12 for the playlists and the parity backlog. A new release will be made soon. |
Summary
This is a third, separate PR. It adds user playlists and records the Jellyfin
parity work as a one-feature-per-PR backlog so the remaining items can land
independently instead of being bundled into the two existing PRs.
Playlists (the only feature implemented here)
Jellyfin parity backlog, one feature per PR
The full table with status and remaining work is in
docs/jellyfin-parity.md. Each item below isintended to be its own PR, in this order:
Server-side parity items (local media scanning, Live TV/DVR, plugins, hardware
transcoding) are called out as separate product decisions, not smuggled into a
playback PR.
Testing