Support sev-snp measurement under crypto_nossl#391
Merged
Conversation
mike-marcacci
requested review from
DGonzalezVillal,
larrydewey and
tylerfanelli
as code owners
tylerfanelli
reviewed
Apr 2, 2026
Member
tylerfanelli
left a comment
tylerfanelli
left a comment
There was a problem hiding this comment.
Can you add a Signed-off-by line to the commit?
DGonzalezVillal
approved these changes
Apr 2, 2026
Member
DGonzalezVillal
left a comment
DGonzalezVillal
left a comment
There was a problem hiding this comment.
LGTM thank you for the PR
Member
|
please sign-off commit |
Signed-off-by: Mike Marcacci <mike.marcacci@gmail.com>
mike-marcacci
force-pushed
the
crypto_nossl_measurement
branch
from
fdd2fcd to
2d9c9ad
Compare
Contributor
Author
|
Just added a sign-off — sorry for the delay! |
tylerfanelli
approved these changes
Apr 3, 2026
Comment on lines
+15
to
+18
| #[cfg(all( | ||
| any(feature = "sev", feature = "snp"), | ||
| any(feature = "openssl", feature = "crypto_nossl") | ||
| ))] |
Member
There was a problem hiding this comment.
Unrelated to this PR, @DGonzalezVillal we should take a serious look on simplifying these combination conditionals. For example, AFAIU any(feature = "sev", feature = "snp") will always be true.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
None of the measurement functionality was supported under the
crypto_nosslfeature.This adds support where doing so is trivial (including
snp_calc_launch_digest, which I needed) but does not add support for functionality that required more substantial changes.