Skip to content

Disable unbuildable case-study libraries on the Veil-support branch #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
larskuhtz wants to merge 1 commit into
base: upgrade-v4.28
Choose a base branch
from
Open

Disable unbuildable case-study libraries on the Veil-support branch #35

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion lakefile.lean
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,10 +115,21 @@ def CaseStudiesRoot : Array Glob :=

@[default_target]
lean_lib Loom {
globs := #[Glob.submodules `Loom]
-- `andSubmodules`: cover the root `Loom` module as well, so consumers
-- importing `Loom` resolve it to this library.
globs := #[Glob.andSubmodules `Loom]
extraDepTargets := #[``downloadDependencies]
}

/- The case-study libraries are disabled on this branch: it upgrades only
the Loom core needed by Veil (see 37fe563), and the case studies were not
ported — `CaseStudies/*` still imports `Loom.MonadAlgebras.NonDetT.Extract`,
which no longer exists here, so these libraries cannot build. Worse, the
`CaseStudies` lib's globs overlap the core (`Glob.submodules `Loom`), so a
consumer that precompiles (e.g. Veil with `precompileModules`) gets
`CaseStudies:shared` pulled into its build and fails on the missing module.
The case studies live on `master`.

lean_lib CaseStudiesBase {
globs := CaseStudiesRoot
}
Expand All @@ -134,3 +145,4 @@ lean_lib Velvet {
lean_lib CaseStudies {
globs := #[Glob.submodules `Loom, Glob.submodules `CaseStudies]
}
-/
Loading