Skip to content

fix(icons): add aria-hidden attribute to all icon components for accessibility(#485) #486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
simon5057 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(icons): add aria-hidden attribute to all icon components for accessibility(#485) #486

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions packages/streamdown/lib/icons.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ type IconProps = SVGProps<SVGSVGElement>;

export const CheckIcon = (props: IconProps) => (
<svg
aria-hidden="true"
color="currentColor"
height={16}
strokeLinejoin="round"
Expand All @@ -23,6 +24,7 @@ export const CheckIcon = (props: IconProps) => (

export const CopyIcon = (props: IconProps) => (
<svg
aria-hidden="true"
color="currentColor"
height={16}
strokeLinejoin="round"
Expand All @@ -41,6 +43,7 @@ export const CopyIcon = (props: IconProps) => (

export const DownloadIcon = (props: IconProps) => (
<svg
aria-hidden="true"
color="currentColor"
height={16}
strokeLinejoin="round"
Expand All @@ -59,6 +62,7 @@ export const DownloadIcon = (props: IconProps) => (

export const Loader2Icon = (props: IconProps) => (
<svg
aria-hidden="true"
color="currentColor"
height={16}
strokeLinejoin="round"
Expand Down Expand Up @@ -121,6 +125,7 @@ export const Loader2Icon = (props: IconProps) => (

export const Maximize2Icon = (props: IconProps) => (
<svg
aria-hidden="true"
color="currentColor"
height={16}
strokeLinejoin="round"
Expand All @@ -139,6 +144,7 @@ export const Maximize2Icon = (props: IconProps) => (

export const RotateCcwIcon = (props: IconProps) => (
<svg
aria-hidden="true"
color="currentColor"
height={16}
strokeLinejoin="round"
Expand All @@ -157,6 +163,7 @@ export const RotateCcwIcon = (props: IconProps) => (

export const XIcon = (props: IconProps) => (
<svg
aria-hidden="true"
color="currentColor"
height={16}
strokeLinejoin="round"
Expand All @@ -175,6 +182,7 @@ export const XIcon = (props: IconProps) => (

export const ExternalLinkIcon = (props: IconProps) => (
<svg
aria-hidden="true"
color="currentColor"
height={16}
strokeLinejoin="round"
Expand All @@ -193,6 +201,7 @@ export const ExternalLinkIcon = (props: IconProps) => (

export const ZoomInIcon = (props: IconProps) => (
<svg
aria-hidden="true"
color="currentColor"
height={16}
strokeLinejoin="round"
Expand All @@ -211,6 +220,7 @@ export const ZoomInIcon = (props: IconProps) => (

export const ZoomOutIcon = (props: IconProps) => (
<svg
aria-hidden="true"
color="currentColor"
height={16}
strokeLinejoin="round"
Expand Down