Skip to content

[test] Deflake shallow-routing #93006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eps1lon merged 1 commit into from
Apr 19, 2026
+19 −11
Merged

[test] Deflake shallow-routing #93006

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 19 additions & 11 deletions test/development/pages-dir/client-navigation/shallow-routing.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/* eslint-env jest */

import { waitFor } from 'next-test-utils'
import { retry, waitFor } from 'next-test-utils'
import path from 'path'
import { nextTestSetup } from 'e2e-utils'

Expand All @@ -14,14 +14,16 @@ describe('Client navigation with shallow routing', () => {

it('should update the url without running getInitialProps', async () => {
const browser = await next.browser('/nav/shallow-routing')
const counter = await browser
await browser
.elementByCss('#increase')
.click()
.elementByCss('#increase')
.click()
.elementByCss('#counter')
.text()
expect(counter).toBe('Counter: 2')

await retry(async () => {
const counter = await browser.elementByCss('#counter').text()
expect(counter).toBe('Counter: 2')
})

const getInitialPropsRunCount = await browser
.elementByCss('#get-initial-props-run-count')
Expand All @@ -33,17 +35,23 @@ describe('Client navigation with shallow routing', () => {

it('should handle the back button and should not run getInitialProps', async () => {
const browser = await next.browser('/nav/shallow-routing')
let counter = await browser
await browser
.elementByCss('#increase')
.click()
.elementByCss('#increase')
.click()
.elementByCss('#counter')
.text()
expect(counter).toBe('Counter: 2')

counter = await browser.back().elementByCss('#counter').text()
expect(counter).toBe('Counter: 1')
await retry(async () => {
const counter = await browser.elementByCss('#counter').text()
expect(counter).toBe('Counter: 2')
})

await browser.back()

await retry(async () => {
const counter = await browser.elementByCss('#counter').text()
expect(counter).toBe('Counter: 1')
})

const getInitialPropsRunCount = await browser
.elementByCss('#get-initial-props-run-count')
Expand Down
Loading