Skip to content

fix: AppType generic parameter applies to props, not pageProps #92963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Jah-yee wants to merge 1 commit into
base: canary
Choose a base branch
from
+2 −1
Open

fix: AppType generic parameter applies to props, not pageProps #92963

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/next/src/shared/lib/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,8 @@ export type AppInitialProps<PageProps = any> = {
export type AppPropsType<
Router extends NextRouter = NextRouter,
PageProps = {},
> = AppInitialProps<PageProps> & {
> = PageProps & {
pageProps: PageProps
Component: NextComponentType<NextPageContext, any, any>
router: Router
__N_SSG?: boolean
Expand Down
Loading