Skip to content

fix: make AppType generic props accessible at top level instead of pageProps #92962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Jah-yee wants to merge 1 commit into
base: canary
Choose a base branch
from
+2 −2
Open

fix: make AppType generic props accessible at top level instead of pageProps #92962

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/next/src/shared/lib/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,8 +167,8 @@ export type AppContextType<Router extends NextRouter = NextRouter> = {
router: Router
}

export type AppInitialProps<PageProps = any> = {
pageProps: PageProps
export type AppInitialProps<PageProps = any> = PageProps & {
pageProps: any
Copy link
Copy Markdown
Contributor

@vercel vercel Bot Apr 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
pageProps: any
pageProps: PageProps

AppInitialProps type change replaces pageProps: PageProps with pageProps: any, silently removing type safety for all consumers that access custom props through pageProps.

Fix on Vercel

}

export type AppPropsType<
Expand Down
Loading