-
Notifications
You must be signed in to change notification settings - Fork 30.9k
Add MCP compile_route tool
#92951
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
lukesandberg
wants to merge
3
commits into
eviction_semantics_for_real_this_time
Choose a base branch
from
followups
base: eviction_semantics_for_real_this_time
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Add MCP compile_route tool
#92951
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -134,9 +134,12 @@ export type ClientState = { | |
| export type ClientStateMap = WeakMap<ws, ClientState> | ||
|
|
||
| // hooks only used by the dev server. | ||
| // subscribeToChanges is optional: omit it to skip wiring HMR subscriptions | ||
| // for one-shot compilations (e.g. the compile_route MCP tool) where there | ||
| // is no client to receive updates and no unsubscribe path. | ||
| type HandleRouteTypeHooks = { | ||
| handleWrittenEndpoint: HandleWrittenEndpoint | ||
| subscribeToChanges: StartChangeSubscription | ||
| subscribeToChanges?: StartChangeSubscription | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. instead of making this be optional would it be better to just pass a no-op subscribe function down? |
||
| } | ||
|
|
||
| export async function handleRouteType({ | ||
|
|
@@ -167,6 +170,8 @@ export async function handleRouteType({ | |
|
|
||
| readyIds?: ReadyIds // dev | ||
|
|
||
| // hooks.subscribeToChanges may be omitted to skip HMR subscriptions for | ||
| // one-shot compilations (e.g. the compile_route MCP tool). | ||
| hooks?: HandleRouteTypeHooks // dev | ||
| }) { | ||
| switch (route.type) { | ||
|
|
@@ -251,7 +256,7 @@ export async function handleRouteType({ | |
| if (dev) { | ||
| // TODO subscriptions should only be caused by the WebSocket connections | ||
| // otherwise we don't known when to unsubscribe and this leaking | ||
| hooks?.subscribeToChanges( | ||
| hooks?.subscribeToChanges?.( | ||
| serverKey, | ||
| false, | ||
| route.dataEndpoint, | ||
|
|
@@ -270,7 +275,7 @@ export async function handleRouteType({ | |
| } | ||
| } | ||
| ) | ||
| hooks?.subscribeToChanges( | ||
| hooks?.subscribeToChanges?.( | ||
| clientKey, | ||
| false, | ||
| route.htmlEndpoint, | ||
|
|
@@ -287,7 +292,7 @@ export async function handleRouteType({ | |
| } | ||
| ) | ||
| if (entrypoints.global.document) { | ||
| hooks?.subscribeToChanges( | ||
| hooks?.subscribeToChanges?.( | ||
| getEntryKey('pages', 'server', '_document'), | ||
| false, | ||
| entrypoints.global.document, | ||
|
|
@@ -344,7 +349,7 @@ export async function handleRouteType({ | |
| if (dev) { | ||
| // TODO subscriptions should only be caused by the WebSocket connections | ||
| // otherwise we don't known when to unsubscribe and this leaking | ||
| hooks?.subscribeToChanges( | ||
| hooks?.subscribeToChanges?.( | ||
| key, | ||
| true, | ||
| route.rscEndpoint, | ||
|
|
@@ -864,7 +869,7 @@ export async function handlePagesErrorRoute({ | |
|
|
||
| const writtenEndpoint = await entrypoints.global.app.writeToDisk() | ||
| hooks.handleWrittenEndpoint(key, writtenEndpoint, false) | ||
| hooks.subscribeToChanges( | ||
| hooks.subscribeToChanges?.( | ||
| key, | ||
| false, | ||
| entrypoints.global.app, | ||
|
|
@@ -893,7 +898,7 @@ export async function handlePagesErrorRoute({ | |
|
|
||
| const writtenEndpoint = await entrypoints.global.document.writeToDisk() | ||
| hooks.handleWrittenEndpoint(key, writtenEndpoint, false) | ||
| hooks.subscribeToChanges( | ||
| hooks.subscribeToChanges?.( | ||
| key, | ||
| false, | ||
| entrypoints.global.document, | ||
|
|
@@ -919,7 +924,7 @@ export async function handlePagesErrorRoute({ | |
|
|
||
| const writtenEndpoint = await entrypoints.global.error.writeToDisk() | ||
| hooks.handleWrittenEndpoint(key, writtenEndpoint, false) | ||
| hooks.subscribeToChanges( | ||
| hooks.subscribeToChanges?.( | ||
| key, | ||
| false, | ||
| entrypoints.global.error, | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it would be clearer to just create the
definitionhere instead of having the ternary belowit could just be 'extraParams' and be unconditionally spread so all the comments are in one place