Improve "make root node" trace attributes#92941
Merged
Conversation
nextjs-bot
added
created-by: Turbopack team
Merging this PR will not alter performance
Comparing 
Footnotes
|
Collaborator
Stats from current PR✅ No significant changes detected📊 All Metrics📖 Metrics GlossaryDev Server Metrics:
Build Metrics:
Change Thresholds:
⚡ Dev Server
📦 Dev Server (Webpack) (Legacy)📦 Dev Server (Webpack)
⚡ Production Builds
📦 Production Builds (Webpack) (Legacy)📦 Production Builds (Webpack)
📦 Bundle SizesBundle Sizes⚡ TurbopackClient Main Bundles
Server Middleware
Build DetailsBuild Manifests
📦 WebpackClient Main Bundles
Polyfills
Pages
Server Edge SSR
Middleware
Build DetailsBuild Manifests
Build Cache
🔄 Shared (bundler-independent)Runtimes
📎 Tarball URL |
lukesandberg
approved these changes
Apr 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Improve the trace span attributes for "make root node" operations in the turbo-tasks backend. Instead of recording only the raw
task_id, the spans now include a human-readable task description (type name + task ID) viadebug_get_task_description.Why?
When profiling or debugging with tracing tools, raw task IDs are opaque and require additional lookups to understand which task is being processed. Including a human-readable task description (e.g.
TaskId(42) MyFunction(args...)) makes traces immediately actionable.Two spans were affected:
"make root node for strongly consistent read"inbackend/mod.rs"make root node for removing collectible"inbackend/operation/update_collectible.rsHow?
debug_get_task_descriptionmethod to theExecuteContexttrait inoperation/mod.rsExecuteContextImplby delegating to the existingbackend.debug_get_task_descriptionmethod (already used in other tracing spans)%task_id(which formats only the ID) withtask = self.debug_get_task_description(task_id)/task = ctx.debug_get_task_description(task_id)in both span definitions