Run the core package gate on Windows#158
Open
narmi924 wants to merge 1 commit into
Open
Conversation
|
@narmi924 is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
narmi924
marked this pull request as ready for review
July 19, 2026 11:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
npm --prefix packages/core run gatecould not run on Windows. Its deterministic core gate crossed several platform boundaries that had only been exercised in a Unix/macOS shape:zig build-libcommands omitted-lc.init.minimal.args.vectoras C strings, although Windows exposes a UTF-16 native argument vector.clock_gettime_nsec_np.-femit-binnames produced PE files that Node could not launch on Windows.Implementation
The gate now links libc consistently for ReleaseSafe and ReleaseFast. The benchmark uses
args.toSlicefor UTF-8 arguments andstd.Io.Timestamp.now(io, .awake)for monotonic timing;.awakeretains the existingCLOCK_UPTIME_RAWmapping on macOS. A shared helper supplies.exeto both emitted and executed benchmark names on Windows while leaving Unix names unchanged.The oracle digest and benchmark workloads are unchanged.
Validation
npm --prefix packages/core run gate4e1140c16ba5569ab73db860894f4ebazig build test-ts-core-e2escripts/gate.sh fast origin/mainwith PR Make build validation portable on Windows #157 temporarily applied in a detached validation worktreeThe temporary application of #157 was needed only because current
mainhas the Windows CRLF root-gate failure addressed there. This branch does not contain #157 and remains an independent two-file package-gate change.No changelog fragment is included because this changes test infrastructure only.