update go-hclog to current version by pjjw · Pull Request #9613 · velero-io/velero

pjjw · 2026-03-12T19:41:35Z

Please add a summary of your change

Updates the logrus wrapper to be compatible with current versions of go-hclog, then updates the go-hclog version.

Does your change fix a particular issue?

No- we made this patch to be able to integrate velero into our codebase, but it seems generally useful, so contributing back.

Please indicate you've done the following:

Accepted the DCO. Commits without the DCO will delay acceptance.
Created a changelog file (make new-changelog) or comment /kind changelog-not-required on this PR.
Updated the corresponding documentation in site/content/docs/main.

kaovilai

Thank you for your contribution! this lgtm.

blackpiglet · 2026-04-14T08:01:20Z

First, please address the error reported in the GitHub actions.

Second, I have a concern about this change. Because the go-hclog is created by Velero to communicate with the plugins, only bump the go-hclog version without bumping the go-plugin version, I'm not sure whether there will be some unexpected failures.
Have you ever tested the Velero server with this change to work with plugins without bumping the go-hclog?

pjjw · 2026-04-16T13:59:44Z

@blackpiglet that error was introduced by your force-push, CI was clean when I submitted this for review, as can be seen here: d94d0d1

i've corrected that and force-pushed again

i'm relying on CI to be sure, but I don't see how a change in go-hclog would result in a change to the go-plugin interfaces.

codecov · 2026-04-16T14:24:43Z

Codecov Report

❌ Patch coverage is 0% with 14 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
pkg/plugin/clientmgmt/process/logrus_adapter.go	0.00%	14 Missing ⚠️

📢 Thoughts on this report? Let us know!

blackpiglet · 2026-04-16T16:51:40Z

@pjjw
The GitHub action error was gone.

I agree that only bumping the go-hclog version should work.

Just out of curiosity, since go-plugin v1.7.0's go-hclog's version is v1.6.3, why not bump the go-plugin?
By that, the go-hclog version will be bumped, too.
https://github.com/hashicorp/go-plugin/blob/v1.7.0/go.mod

pjjw · 2026-04-16T16:54:41Z

@blackpiglet fine with that- was attempting to make a minimal edit here, but up to you if you want me to bump that as well, just let me know!

pjjw · 2026-04-16T17:08:42Z

@blackpiglet have updated go-plugin as well to match.

pjjw · 2026-04-16T18:03:43Z

sorry, somehow missed the go mod tidy. fixed.

Signed-off-by: Peter Woodman <peter@shortbus.org>

pjjw · 2026-04-16T21:22:58Z

gahh, apologies- in rebasing to current main i accidentally sheared off a critical part of the change. should be in a good state now.

pjjw · 2026-04-22T21:34:11Z

@kaovilai @blackpiglet either of you have write privileges to merge this?

…#9613) Signed-off-by: Peter Woodman <peter@shortbus.org>

…#9613) Signed-off-by: Peter Woodman <peter@shortbus.org> Signed-off-by: emirot <emirot.nolan@gmail.com>

@blackpiglet

* fix: lint permission issue Signed-off-by: emirot <emirot.nolan@gmail.com> * fix: lint permission issue Signed-off-by: emirot <emirot.nolan@gmail.com> * Set permissions to the actions This commit update the actions "Auto Assign Author", "Auto Label PRs", and "Auto Request Review" Signed-off-by: Daniel Jiang <daniel.jiang@broadcom.com> Signed-off-by: emirot <emirot.nolan@gmail.com> * Fix wildcard expansion when includes is empty and excludes has wildcards (#9684) * Fix wildcard expansion when includes is empty and excludes has wildcards When a Backup CR is applied via kubectl with empty includedNamespaces and a wildcard in excludedNamespaces, ShouldExpandWildcards triggers expansion. The empty includes expands to nil, but wildcardExpanded is set to true, causing ShouldInclude to return false for all namespaces. Populate expanded includes with all active namespaces when the original includes was empty (meaning "include all") so that the wildcardExpanded check does not falsely reject everything. Signed-off-by: Joseph <jvaikath@redhat.com> * Changelog Signed-off-by: Joseph <jvaikath@redhat.com> * Normalize empty includes to * instead of active namespaces list This ensures consistent behavior between CLI and kubectl-apply paths for Namespace CR inclusion when excludes contain wildcards. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Joseph <jvaikath@redhat.com> * Move empty includes normalization to backup controller Instead of normalizing empty IncludedNamespaces to ["*"] in the collections layer's ExpandIncludesExcludes, do it earlier in prepareBackupRequest. This ensures the spec is correct before any downstream processing. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Joseph <jvaikath@redhat.com> * Update TestProcessBackupCompletions for wildcard normalization Add IncludedNamespaces: []string{"*"} to all expected BackupSpec structs, reflecting the new prepareBackupRequest normalization. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Joseph <jvaikath@redhat.com> * Add checks around empty includenamespaces Signed-off-by: Joseph <jvaikath@redhat.com> * gofmt Signed-off-by: Joseph <jvaikath@redhat.com> --------- Signed-off-by: Joseph <jvaikath@redhat.com> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: emirot <emirot.nolan@gmail.com> * update hashicorp/go-hclog and go-plugin to current version (#9613) Signed-off-by: Peter Woodman <peter@shortbus.org> Signed-off-by: emirot <emirot.nolan@gmail.com> * fix: honor -stderrthreshold when -logtostderr is true (default) klog v2 defaults -logtostderr to true, which silently ignores the -stderrthreshold flag — all log levels are unconditionally sent to stderr. This makes it impossible for log-aggregation systems to filter by severity. Bump klog to v2.140.0 and opt into the fixed behavior by setting legacy_stderr_threshold_behavior=false and stderrthreshold=INFO (which preserves current output while letting users override via CLI flags). Ref: kubernetes/klog#212, kubernetes/klog#432 Signed-off-by: Pierluigi Lenoci <pierluigilenoci@gmail.com> Signed-off-by: emirot <emirot.nolan@gmail.com> * fix: add changelog and nolint explanation for CI Add missing changelog entry for PR 9654 (fixes Changelog Check). Add explanation to //nolint:errcheck directives (fixes nolintlint). Signed-off-by: Pierluigi Lenoci <pierluigilenoci@gmail.com> Signed-off-by: emirot <emirot.nolan@gmail.com> * Remove Restic code path from PodVolumeRestore. Signed-off-by: Xun Jiang <xun.jiang@broadcom.com> Signed-off-by: emirot <emirot.nolan@gmail.com> * Bump go.opentelemetry.io/otel from 1.40.0 to 1.41.0 Bumps [go.opentelemetry.io/otel](https://github.com/open-telemetry/opentelemetry-go) from 1.40.0 to 1.41.0. - [Release notes](https://github.com/open-telemetry/opentelemetry-go/releases) - [Changelog](https://github.com/open-telemetry/opentelemetry-go/blob/main/CHANGELOG.md) - [Commits](open-telemetry/opentelemetry-go@v1.40.0...v1.41.0) --- updated-dependencies: - dependency-name: go.opentelemetry.io/otel dependency-version: 1.41.0 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: emirot <emirot.nolan@gmail.com> * Fix error in auto-request-review action Per action.yml of the action, the token is required. https://github.com/necojackarc/auto-request-review/blob/e89da1a8cd7c8c16d9de9c6e763290b6b0e3d424/action.yml#L8 Signed-off-by: Daniel Jiang <daniel.jiang@broadcom.com> Signed-off-by: emirot <emirot.nolan@gmail.com> * fix go-releaser upload error Signed-off-by: Lyndon-Li <lyonghui@vmware.com> Signed-off-by: emirot <emirot.nolan@gmail.com> * add concurrency limit to go-releaser Signed-off-by: Lyndon-Li <lyonghui@vmware.com> Signed-off-by: emirot <emirot.nolan@gmail.com> * Bump go.opentelemetry.io/otel/sdk from 1.40.0 to 1.43.0 (#9692) Bumps [go.opentelemetry.io/otel/sdk](https://github.com/open-telemetry/opentelemetry-go) from 1.40.0 to 1.43.0. - [Release notes](https://github.com/open-telemetry/opentelemetry-go/releases) - [Changelog](https://github.com/open-telemetry/opentelemetry-go/blob/main/CHANGELOG.md) - [Commits](open-telemetry/opentelemetry-go@v1.40.0...v1.43.0) --- updated-dependencies: - dependency-name: go.opentelemetry.io/otel/sdk dependency-version: 1.43.0 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: emirot <emirot.nolan@gmail.com> * fix(lint): fix lint local Signed-off-by: emirot <emirot.nolan@gmail.com> * Apply suggestion from @blackpiglet https://github.com/velero-io/velero/pull/9740/changes#r3151366281 Signed-off-by: Tiger Kaovilai <passawit.kaovilai@gmail.com> --------- Signed-off-by: emirot <emirot.nolan@gmail.com> Signed-off-by: Daniel Jiang <daniel.jiang@broadcom.com> Signed-off-by: Joseph <jvaikath@redhat.com> Signed-off-by: Peter Woodman <peter@shortbus.org> Signed-off-by: Pierluigi Lenoci <pierluigilenoci@gmail.com> Signed-off-by: Xun Jiang <xun.jiang@broadcom.com> Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Lyndon-Li <lyonghui@vmware.com> Signed-off-by: Tiger Kaovilai <passawit.kaovilai@gmail.com> Co-authored-by: Daniel Jiang <daniel.jiang@broadcom.com> Co-authored-by: Joseph Antony Vaikath <jvaikath@redhat.com> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Co-authored-by: peter woodman <peter@shortbus.org> Co-authored-by: Pierluigi Lenoci <pierluigilenoci@gmail.com> Co-authored-by: Xun Jiang <xun.jiang@broadcom.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Lyndon-Li <lyonghui@vmware.com> Co-authored-by: Tiger Kaovilai <passawit.kaovilai@gmail.com>

@blackpiglet

* fix: lint permission issue Signed-off-by: emirot <emirot.nolan@gmail.com> * fix: lint permission issue Signed-off-by: emirot <emirot.nolan@gmail.com> * Set permissions to the actions This commit update the actions "Auto Assign Author", "Auto Label PRs", and "Auto Request Review" Signed-off-by: Daniel Jiang <daniel.jiang@broadcom.com> Signed-off-by: emirot <emirot.nolan@gmail.com> * Fix wildcard expansion when includes is empty and excludes has wildcards (velero-io#9684) * Fix wildcard expansion when includes is empty and excludes has wildcards When a Backup CR is applied via kubectl with empty includedNamespaces and a wildcard in excludedNamespaces, ShouldExpandWildcards triggers expansion. The empty includes expands to nil, but wildcardExpanded is set to true, causing ShouldInclude to return false for all namespaces. Populate expanded includes with all active namespaces when the original includes was empty (meaning "include all") so that the wildcardExpanded check does not falsely reject everything. Signed-off-by: Joseph <jvaikath@redhat.com> * Changelog Signed-off-by: Joseph <jvaikath@redhat.com> * Normalize empty includes to * instead of active namespaces list This ensures consistent behavior between CLI and kubectl-apply paths for Namespace CR inclusion when excludes contain wildcards. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Joseph <jvaikath@redhat.com> * Move empty includes normalization to backup controller Instead of normalizing empty IncludedNamespaces to ["*"] in the collections layer's ExpandIncludesExcludes, do it earlier in prepareBackupRequest. This ensures the spec is correct before any downstream processing. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Joseph <jvaikath@redhat.com> * Update TestProcessBackupCompletions for wildcard normalization Add IncludedNamespaces: []string{"*"} to all expected BackupSpec structs, reflecting the new prepareBackupRequest normalization. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Joseph <jvaikath@redhat.com> * Add checks around empty includenamespaces Signed-off-by: Joseph <jvaikath@redhat.com> * gofmt Signed-off-by: Joseph <jvaikath@redhat.com> --------- Signed-off-by: Joseph <jvaikath@redhat.com> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: emirot <emirot.nolan@gmail.com> * update hashicorp/go-hclog and go-plugin to current version (velero-io#9613) Signed-off-by: Peter Woodman <peter@shortbus.org> Signed-off-by: emirot <emirot.nolan@gmail.com> * fix: honor -stderrthreshold when -logtostderr is true (default) klog v2 defaults -logtostderr to true, which silently ignores the -stderrthreshold flag — all log levels are unconditionally sent to stderr. This makes it impossible for log-aggregation systems to filter by severity. Bump klog to v2.140.0 and opt into the fixed behavior by setting legacy_stderr_threshold_behavior=false and stderrthreshold=INFO (which preserves current output while letting users override via CLI flags). Ref: kubernetes/klog#212, kubernetes/klog#432 Signed-off-by: Pierluigi Lenoci <pierluigilenoci@gmail.com> Signed-off-by: emirot <emirot.nolan@gmail.com> * fix: add changelog and nolint explanation for CI Add missing changelog entry for PR 9654 (fixes Changelog Check). Add explanation to //nolint:errcheck directives (fixes nolintlint). Signed-off-by: Pierluigi Lenoci <pierluigilenoci@gmail.com> Signed-off-by: emirot <emirot.nolan@gmail.com> * Remove Restic code path from PodVolumeRestore. Signed-off-by: Xun Jiang <xun.jiang@broadcom.com> Signed-off-by: emirot <emirot.nolan@gmail.com> * Bump go.opentelemetry.io/otel from 1.40.0 to 1.41.0 Bumps [go.opentelemetry.io/otel](https://github.com/open-telemetry/opentelemetry-go) from 1.40.0 to 1.41.0. - [Release notes](https://github.com/open-telemetry/opentelemetry-go/releases) - [Changelog](https://github.com/open-telemetry/opentelemetry-go/blob/main/CHANGELOG.md) - [Commits](open-telemetry/opentelemetry-go@v1.40.0...v1.41.0) --- updated-dependencies: - dependency-name: go.opentelemetry.io/otel dependency-version: 1.41.0 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: emirot <emirot.nolan@gmail.com> * Fix error in auto-request-review action Per action.yml of the action, the token is required. https://github.com/necojackarc/auto-request-review/blob/e89da1a8cd7c8c16d9de9c6e763290b6b0e3d424/action.yml#L8 Signed-off-by: Daniel Jiang <daniel.jiang@broadcom.com> Signed-off-by: emirot <emirot.nolan@gmail.com> * fix go-releaser upload error Signed-off-by: Lyndon-Li <lyonghui@vmware.com> Signed-off-by: emirot <emirot.nolan@gmail.com> * add concurrency limit to go-releaser Signed-off-by: Lyndon-Li <lyonghui@vmware.com> Signed-off-by: emirot <emirot.nolan@gmail.com> * Bump go.opentelemetry.io/otel/sdk from 1.40.0 to 1.43.0 (velero-io#9692) Bumps [go.opentelemetry.io/otel/sdk](https://github.com/open-telemetry/opentelemetry-go) from 1.40.0 to 1.43.0. - [Release notes](https://github.com/open-telemetry/opentelemetry-go/releases) - [Changelog](https://github.com/open-telemetry/opentelemetry-go/blob/main/CHANGELOG.md) - [Commits](open-telemetry/opentelemetry-go@v1.40.0...v1.43.0) --- updated-dependencies: - dependency-name: go.opentelemetry.io/otel/sdk dependency-version: 1.43.0 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: emirot <emirot.nolan@gmail.com> * fix(lint): fix lint local Signed-off-by: emirot <emirot.nolan@gmail.com> * Apply suggestion from @blackpiglet https://github.com/velero-io/velero/pull/9740/changes#r3151366281 Signed-off-by: Tiger Kaovilai <passawit.kaovilai@gmail.com> --------- Signed-off-by: emirot <emirot.nolan@gmail.com> Signed-off-by: Daniel Jiang <daniel.jiang@broadcom.com> Signed-off-by: Joseph <jvaikath@redhat.com> Signed-off-by: Peter Woodman <peter@shortbus.org> Signed-off-by: Pierluigi Lenoci <pierluigilenoci@gmail.com> Signed-off-by: Xun Jiang <xun.jiang@broadcom.com> Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Lyndon-Li <lyonghui@vmware.com> Signed-off-by: Tiger Kaovilai <passawit.kaovilai@gmail.com> Co-authored-by: Daniel Jiang <daniel.jiang@broadcom.com> Co-authored-by: Joseph Antony Vaikath <jvaikath@redhat.com> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Co-authored-by: peter woodman <peter@shortbus.org> Co-authored-by: Pierluigi Lenoci <pierluigilenoci@gmail.com> Co-authored-by: Xun Jiang <xun.jiang@broadcom.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Lyndon-Li <lyonghui@vmware.com> Co-authored-by: Tiger Kaovilai <passawit.kaovilai@gmail.com> Signed-off-by: emirot <emirot.nolan@gmail.com>

github-actions Bot added the Dependencies Pull requests that update a dependency file label Mar 12, 2026

pjjw force-pushed the pjjw/go-hclog-update branch 2 times, most recently from 34ea3c5 to d94d0d1 Compare March 12, 2026 19:44

github-actions Bot added the has-changelog label Mar 12, 2026

pjjw marked this pull request as ready for review March 12, 2026 20:22

github-actions Bot assigned pjjw Mar 12, 2026

github-actions Bot requested review from anshulahuja98 and shubham-pampattiwar March 12, 2026 20:22

kaovilai previously approved these changes Apr 14, 2026

View reviewed changes

blackpiglet force-pushed the pjjw/go-hclog-update branch from d94d0d1 to 2ddc2ba Compare April 14, 2026 07:42

pjjw dismissed kaovilai’s stale review via 61e98fd April 16, 2026 13:59

pjjw force-pushed the pjjw/go-hclog-update branch from 2ddc2ba to 61e98fd Compare April 16, 2026 13:59

pjjw force-pushed the pjjw/go-hclog-update branch 5 times, most recently from 90419bc to 8c3e66f Compare April 16, 2026 17:08

kaovilai previously approved these changes Apr 16, 2026

View reviewed changes

pjjw dismissed kaovilai’s stale review via 6a87759 April 16, 2026 18:03

pjjw force-pushed the pjjw/go-hclog-update branch from 8c3e66f to 6a87759 Compare April 16, 2026 18:03

kaovilai previously approved these changes Apr 16, 2026

View reviewed changes

pjjw dismissed kaovilai’s stale review via cbffe05 April 16, 2026 20:18

pjjw force-pushed the pjjw/go-hclog-update branch from 6a87759 to cbffe05 Compare April 16, 2026 20:18

kaovilai previously approved these changes Apr 16, 2026

View reviewed changes

update hashicorp/go-hclog and go-plugin to current version

58fbc22

Signed-off-by: Peter Woodman <peter@shortbus.org>

pjjw dismissed kaovilai’s stale review via 58fbc22 April 16, 2026 21:18

pjjw force-pushed the pjjw/go-hclog-update branch from cbffe05 to 58fbc22 Compare April 16, 2026 21:18

kaovilai approved these changes Apr 16, 2026

View reviewed changes

blackpiglet approved these changes Apr 20, 2026

View reviewed changes

kaovilai merged commit 7549408 into velero-io:main Apr 23, 2026
56 of 58 checks passed

priyansh17 pushed a commit to priyansh17/velero that referenced this pull request Apr 23, 2026

update hashicorp/go-hclog and go-plugin to current version (velero-io…

edb5b3f

…#9613) Signed-off-by: Peter Woodman <peter@shortbus.org>

emirot pushed a commit to emirot/velero that referenced this pull request Apr 27, 2026

update hashicorp/go-hclog and go-plugin to current version (velero-io…

c0f4eda

…#9613) Signed-off-by: Peter Woodman <peter@shortbus.org> Signed-off-by: emirot <emirot.nolan@gmail.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

update go-hclog to current version#9613

update go-hclog to current version#9613
kaovilai merged 1 commit intovelero-io:mainfrom
pjjw:pjjw/go-hclog-update

pjjw commented Mar 12, 2026 •

edited

Loading

Uh oh!

kaovilai left a comment

Uh oh!

blackpiglet commented Apr 14, 2026

Uh oh!

pjjw commented Apr 16, 2026

Uh oh!

codecov Bot commented Apr 16, 2026 •

edited

Loading

Uh oh!

blackpiglet commented Apr 16, 2026

Uh oh!

pjjw commented Apr 16, 2026

Uh oh!

pjjw commented Apr 16, 2026

Uh oh!

pjjw commented Apr 16, 2026

Uh oh!

pjjw commented Apr 16, 2026

Uh oh!

pjjw commented Apr 22, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

pjjw commented Mar 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Please add a summary of your change

Does your change fix a particular issue?

Please indicate you've done the following:

Uh oh!

kaovilai left a comment

Choose a reason for hiding this comment

Uh oh!

blackpiglet commented Apr 14, 2026

Uh oh!

pjjw commented Apr 16, 2026

Uh oh!

codecov Bot commented Apr 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

blackpiglet commented Apr 16, 2026

Uh oh!

pjjw commented Apr 16, 2026

Uh oh!

pjjw commented Apr 16, 2026

Uh oh!

pjjw commented Apr 16, 2026

Uh oh!

pjjw commented Apr 16, 2026

Uh oh!

pjjw commented Apr 22, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

pjjw commented Mar 12, 2026 •

edited

Loading

codecov Bot commented Apr 16, 2026 •

edited

Loading